Fix the issues reported by phpcs

Hi,

I have reviewed patch #2, it applied cleanly and resolved some of the issues mentioned above but still getting below errors/warnings that need to be fixed:

FILE: /adv_varnish/adv_varnish.module
---------------------------------------------------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AND 2 WARNINGS AFFECTING 6 LINES
---------------------------------------------------------------------------------------------------------------------------------------------
  76 | ERROR   | [ ] The array declaration extends to column 108 (the limit is 80). The array content should be split up over multiple lines
  77 | ERROR   | [ ] The array declaration extends to column 98 (the limit is 80). The array content should be split up over multiple lines
 175 | WARNING | [x] Inline @var declarations should use the /** */ delimiters
 227 | ERROR   | [x] Expected 1 space after FUNCTION keyword; 0 found
 229 | ERROR   | [x] Array indentation error, expected 6 spaces but found 4
 229 | ERROR   | [x] Closing parenthesis of array declaration must be on a new line
 251 | WARNING | [x] Inline @var declarations should use the /** */ delimiters
---------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------


FILE: /adv_varnish/src/CacheManager.php
----------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------------------------------
 187 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 354 | WARNING | Line exceeds 80 characters; contains 113 characters
----------------------------------------------------------------------------------------------

So, moving this to Needs Work.

Thanks!

Fixed most of the issues.
Only remaining issue is of DI.

I applied MR!13 and I still encountered some issues after I ran vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,js,info,txt,md,yml,twig modules/custom/adv_varnish-3373546/

FILE: /var/www/html/drupal-contri-d10/modules/custom/adv_varnish-3373546/src/EventSubscriber/CacheableResponseSubscriber.php
----------------------------------------------------------------------------------------------------------------------------
FOUND 11 ERRORS AFFECTING 9 LINES
----------------------------------------------------------------------------------------------------------------------------
 80 | ERROR | [x] The first parameter of a multi-line function declaration must be on the line after the opening bracket
 81 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
 82 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
 83 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
 84 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
 85 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
 86 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
 87 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
 88 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
 88 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
 88 | ERROR | [x] The closing parenthesis of a multi-line function declaration must be on a new line
----------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 11 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/drupal-contri-d10/modules/custom/adv_varnish-3373546/src/Form/CacheSettingsForm.php
-------------------------------------------------------------------------------------------------------------------------
FOUND 7 ERRORS AFFECTING 5 LINES
-------------------------------------------------------------------------------------------------------------------------
 61 | ERROR | [x] The first parameter of a multi-line function declaration must be on the line after the opening bracket
 62 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
 63 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
 64 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
 65 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
 65 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
 65 | ERROR | [x] The closing parenthesis of a multi-line function declaration must be on a new line
-------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/drupal-contri-d10/modules/custom/adv_varnish-3373546/src/Form/DeflateForm.php
-------------------------------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 3 LINES
-------------------------------------------------------------------------------------------------------------------------
 49 | ERROR | [x] The first parameter of a multi-line function declaration must be on the line after the opening bracket
 50 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
 51 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
 51 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
 51 | ERROR | [x] The closing parenthesis of a multi-line function declaration must be on a new line
-------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/drupal-contri-d10/modules/custom/adv_varnish-3373546/src/Form/CacheBlockForm.php
-------------------------------------------------------------------------------------------------------------------------
FOUND 9 ERRORS AFFECTING 7 LINES
-------------------------------------------------------------------------------------------------------------------------
 50 | ERROR | [x] The first parameter of a multi-line function declaration must be on the line after the opening bracket
 51 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
 52 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
 53 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
 54 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
 55 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
 56 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
 56 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
 56 | ERROR | [x] The closing parenthesis of a multi-line function declaration must be on a new line
-------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 9 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/drupal-contri-d10/modules/custom/adv_varnish-3373546/src/CookieManager.php
-------------------------------------------------------------------------------------------------------------------------
FOUND 9 ERRORS AFFECTING 7 LINES
-------------------------------------------------------------------------------------------------------------------------
 90 | ERROR | [x] The first parameter of a multi-line function declaration must be on the line after the opening bracket
 91 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
 92 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
 93 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
 94 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
 95 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
 96 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
 96 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
 96 | ERROR | [x] The closing parenthesis of a multi-line function declaration must be on a new line
-------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 9 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/drupal-contri-d10/modules/custom/adv_varnish-3373546/src/RequestHandler.php
-------------------------------------------------------------------------------------------------------------------------
FOUND 8 ERRORS AFFECTING 6 LINES
-------------------------------------------------------------------------------------------------------------------------
 87 | ERROR | [x] The first parameter of a multi-line function declaration must be on the line after the opening bracket
 88 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
 89 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
 90 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
 91 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
 92 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
 92 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
 92 | ERROR | [x] The closing parenthesis of a multi-line function declaration must be on a new line
-------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/drupal-contri-d10/modules/custom/adv_varnish-3373546/src/Controller/ESIBlockController.php
-------------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------------------------------
 42 | ERROR | [x] The first parameter of a multi-line function declaration must be on the line after the opening bracket
 43 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
 43 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
 43 | ERROR | [x] The closing parenthesis of a multi-line function declaration must be on a new line
-------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/drupal-contri-d10/modules/custom/adv_varnish-3373546/src/Controller/UserBlocksController.php
-------------------------------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 3 LINES
-------------------------------------------------------------------------------------------------------------------------
 53 | ERROR | [x] The first parameter of a multi-line function declaration must be on the line after the opening bracket
 54 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
 55 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
 55 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
 55 | ERROR | [x] The closing parenthesis of a multi-line function declaration must be on a new line
-------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/drupal-contri-d10/modules/custom/adv_varnish-3373546/src/CacheManager.php
----------------------------------------------------------------------------------------------------------------------------
FOUND 13 ERRORS AND 1 WARNING AFFECTING 12 LINES
----------------------------------------------------------------------------------------------------------------------------
 155 | ERROR   | [x] The first parameter of a multi-line function declaration must be on the line after the opening bracket
 156 | ERROR   | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
 157 | ERROR   | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
 158 | ERROR   | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
 159 | ERROR   | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
 160 | ERROR   | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
 161 | ERROR   | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
 162 | ERROR   | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
 163 | ERROR   | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
 164 | ERROR   | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
 165 | ERROR   | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
 165 | ERROR   | [x] Multi-line function declarations must have a trailing comma after the last parameter
 165 | ERROR   | [x] The closing parenthesis of a multi-line function declaration must be on a new line
 187 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
----------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 13 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/drupal-contri-d10/modules/custom/adv_varnish-3373546/js/adv_varnish_user_data.js
----------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------
 28 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
----------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------

Time: 949ms; Memory: 14MB

That was fixed https://www.drupal.org/project/adv_varnish/issues/3576436