Problem/Motivation

The Varbase media header doesn't reflect on the preview

Steps to reproduce

  1. Create a node that has Varbase media header
  2. Choose media header
  3. Preview the node

Proposed resolution

adding the following code when ever getParameter('node') is used

 if (empty($node)){
      $node = $this->routeMatch->getParameter('node_preview');
}

Remaining tasks

Varbase update type

  • ✅ No Update
  • ➖ Optional Update
  • ➖ Forced Update
  • ➖ Forced Update if Unchanged

User interface changes

Tested in Varbase ~9.0.0

Test Basic page preview of the Full Content view mode - with Media Header
Test Basic page preview of the Full Content view mode  - with Media Header  - in Varbase ~9.0.0

Test Basic page preview of the Teaser/Card view mode - with Media Header
Test Basic page preview of the Teaser/Card view mode  - with Media Header  - in Varbase ~9.0.0

Test Basic page - front-end view for the full content view mode - with Media Header
Test Basic page - front-end view for the full content view mode  - with Media Header  - in Varbase ~9.0.0

Test not saved yet new Basic page preview of the Full Content view - with Media Header
Test not saved yet new Basic page preview of the Full Content view  - with Media Header  - in Varbase ~9.0.0

Test not saved yet new Basic page preview of the Teaser/Card view mode - with Media Header
Test not saved yet new Basic page preview of the Teaser/Card view mode  - with Media Header  - in Varbase ~9.0.0


Tested in Varbase ~10.0.0

Test Basic page preview of the Full Content view mode - with Media Header
Test Basic page preview of the Full Content view mode  - with Media Header  - in Varbase ~10.0.0

Test Basic page preview of the Teaser/Card view mode - with Media Header
Test Basic page preview of the Teaser/Card view mode  - with Media Header  - in Varbase ~10.0.0

Test Basic page - front-end view for the full content view mode - with Media Header
Test Basic page - front-end view for the full content view mode  - with Media Header  - in Varbase ~10.0.0

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • Issue #3373397 by Ahmad Khader: Improved the preview option view for the full content view mode when a media header is present

Comments

Ahmad Khader created an issue. See original summary.

ahmad khader’s picture

Category: Feature request » Bug report
StatusFileSize
new1.61 KB

adding a patch to support the preview

ahmad khader’s picture

Title: add support to preview node » Add support to preview node
ahmad khader’s picture

StatusFileSize
new1.55 KB

Rerolling patch to 9.0.5 version

ahmad khader’s picture

ahmad khader’s picture

StatusFileSize
new1.67 KB

Update the patch to the latest version of 10.0.x

ahmad khader’s picture

StatusFileSize
new1.67 KB

Update the patch to the latest version of 9.0.x

ahmad khader’s picture

Issue summary: View changes
StatusFileSize
new481.32 KB
new148.79 KB
new478.08 KB
ahmad khader’s picture

Status: Active » Needs review
rajab natshah’s picture

Version: 10.0.x-dev » 9.0.x-dev
Issue summary: View changes

Thank you, Ahmad, for reporting and patching.
To be committed to both 9.0.x and 10.0.x branches.

Needs to test that this fix dose not have aggregation or performance issues after #3319641: Add support to enable Varbase Media Header on Taxonomy Terms entity type

rajab natshah’s picture

rajab natshah’s picture

Title: Add support to preview node » Improve the preview option view for the full content view mode when a media header is present

rajab natshah’s picture

Assigned: Unassigned » rajab natshah
Status: Needs review » Needs work

It only should show up for the "Full Content" view mode
Not other Teasers or Cards view modes

  • Rajab Natshah committed 4d08ddf4 on 9.0.x
    Issue #3373397: Improve the preview option view for the full content...

  • Rajab Natshah committed 99f90ee1 on 10.0.x
    Issue #3373397: Improve the preview option view for the full content...
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes
  • ❌ Developer Documentation support on feature change/addition
  • ❌ User Guide Documentation support on feature change/addition
Needs change for Varbase ~9.0.0
Configuring Varbase Media Header
Needs change for Varbase ~10.0.0
Configuring Varbase Media Header
rajab natshah’s picture

  • ✅ Developer Documentation support on feature change/addition
  • ✅ User Guide Documentation support on feature change/addition
Changed for Varbase ~9.0.0
Configuring Varbase Media Header
Changed for Varbase ~10.0.0
Configuring Varbase Media Header
rajab natshah’s picture

Assigned: mohammed j. razem » Unassigned
Status: Needs review » Fixed
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes

✅ Released varbase-9.0.15

rajab natshah’s picture

Issue summary: View changes

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.