Problem/Motivation

We can add the media header only on contents types, so when I tried to add a media header on the term page I couldn't do it, so I handled to add a media header on the term page

Steps to reproduce

No fields will be added to the taxonomy, if we add the field manually we will need to include the template and block manually

Proposed resolution

  • Add a new entity option, which is a Taxonomy term, with a node entity with some enhancement.
              // Planed for allowed entity types to have node, taxonomy.
              // more other entity types if needed.
              $allowed_entity_types = ['node', 'taxonomy_term'];
         
  • Refine the code logic for constructing the block by ensuring a more organized order.
  • Implement efficient block cache context and logic management.
  • Group bundles for supported entity types to improve code structure and maintainability.
  • Import managed Entity Type configs for supported entity types. Only when needed.

As a test Example:
The varbase_media_header.settings.yml schema and configs looks as the following when enabled for page, varbase_blog content types and blog_categories terms:

varbase_media_header_settings:
  node:
    page: page
    varbase_blog: varbase_blog
    landing_page_lb: 0
    varbase_heroslider_media: 0
  taxonomy_term:
    blog_categories: blog_categories
    tags: 0
hide_breadcrumbs: false

That is covered with the same config schema

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ✅ Developer Documentation support on feature change/addition
    Changed for Varbase ~9.0.0
    Configuring Varbase Media Header
    Changed for Varbase ~10.0.0
    Configuring Varbase Media Header
  • ✅ User Guide Documentation support on feature change/addition
  • ✅ Accessibility and Readability
  • ✅ Code review from 1 Varbase core team member
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Update Release Notes and Update Helper on new feature change/addition
  • ❌ Release varbase-9.0.15, varbase_media_header-9.0.6, varbase-10.0.0-beta1, varbase_media_header-10.0.0-alpha1

Varbase update type

  • ✅ No Update
  • ➖ Optional Update
  • ➖ Forced Update
  • ➖ Forced Update if Unchanged

User interface changes

Varbase Media Header Settings
Varbase Media Header Settings

Configure block - Varbase Media Header
Configure block - Varbase Media Header

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • Issue #3319641 by YazanMajadba: Added support to enable Varbase Media Header on Taxonomy Terms entity type
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

YazanMajadba created an issue. See original summary.

rajab natshah’s picture

Title: [Support] Add the media header on term page » Add support to enable Varbase media header on Taxonomy Terms
Category: Support request » Feature request
rajab natshah’s picture

Title: Add support to enable Varbase media header on Taxonomy Terms » Add support to enable Varbase Media Header on Taxonomy Terms entity type
rajab natshah’s picture

Assigned: yazanmajadba » Unassigned
rajab natshah’s picture

Version: 9.0.4 » 9.0.x-dev
rajab natshah’s picture

Status: Needs review » Needs work

Thank you, Yazan, for the epic work on this new feature.

Recommended using the issue fork contribution workflow. Creating issue forks and merge requests.

Keep Conventions in Mind

Recommended following Drupal coding standards and naming conventions.

yazanmajadba’s picture

Status: Needs work » Needs review
StatusFileSize
new13.37 KB

Thanks Rajab

  • I removed the file
  • I checked the standards (No errors)

rajab natshah’s picture

Assigned: Unassigned » rajab natshah
rajab natshah’s picture

Status: Needs review » Needs work
rajab natshah’s picture

Status: Needs work » Active

  • Rajab Natshah committed 928d90ae on 10.0.x
    Issue #3319641: Add support to enable Varbase Media Header on Taxonomy...

  • Rajab Natshah committed ca5e9ac7 on 9.0.x
    Issue #3319641: Add support to enable Varbase Media Header on Taxonomy...

  • Rajab Natshah committed 7254f9ca on 9.0.x
    Issue #3319641: Add support to enable Varbase Media Header on Taxonomy...

  • Rajab Natshah committed d4d87a96 on 10.0.x
    Issue #3319641: Add support to enable Varbase Media Header on Taxonomy...
rajab natshah’s picture

rajab natshah’s picture

Issue summary: View changes

  • Rajab Natshah committed 010a83be on 9.0.x
    Issue #3319641: Import managed Entity Type configs for supported entity...

  • Rajab Natshah committed 29b780ef on 10.0.x
    Issue #3319641: Import managed Entity Type configs for supported entity...
rajab natshah’s picture

Issue summary: View changes

  • Rajab Natshah committed d9a3de47 on 9.0.x
    Issue #3319641: Import managed Entity Type configs for supported entity...

  • Rajab Natshah committed 0fa5f0ed on 9.0.x
    Issue #3319641: Import managed Entity Type configs for supported entity...
rajab natshah’s picture

Status: Active » Needs review

  • Rajab Natshah committed 86f6a23f on 10.0.x
    Issue #3319641: Import managed Entity Type configs for supported entity...
rajab natshah’s picture

Assigned: rajab natshah » Unassigned
Issue summary: View changes
  • ❌ Developer Documentation support on feature change/addition
  • ❌ User Guide Documentation support on feature change/addition
Needs change for Varbase ~9.0.0
  • New screenshots to cover the Taxonomy Terms new feature
  • Change of steps

Configuring Varbase Media Header

Needs change for Varbase ~10.0.0
  • New screenshots with The Gin Admin theme
  • Change of steps

Configuring Varbase Media Header

rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes

That is covered with the same config schema

rajab natshah’s picture

  • ✅ Developer Documentation support on feature change/addition
  • ✅ User Guide Documentation support on feature change/addition
Changed for Varbase ~9.0.0
Configuring Varbase Media Header
Changed for Varbase ~10.0.0
Configuring Varbase Media Header
rajab natshah’s picture

Assigned: mohammed j. razem » Unassigned
Status: Needs review » Fixed
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes

✅ Released varbase-9.0.15

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.