Needs review
Project:
Config Track
Version:
1.0.0-alpha1
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
6 Jul 2023 at 11:08 UTC
Updated:
10 Mar 2026 at 05:41 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
satish_kumar commentedHello, @urvashi_vora thanks for the patch, I have applied your patch and ran successfully.
These are the steps I followed:
1. Took clone from git version 1.0.x in drupal 10.1.x
2. Ran this command:
3. Applied your patch and, again ran phpcs command
found errors
4. I have fixed that error with phpcbf.
Ran this command to fix the errors:
again ran phpcs command
found no errors.
Please review.
Comment #4
aayushmankotia commentedHi @Satish_kumar
I have created a patch to address all the PHP coding standard issues. Please review.
Comment #5
a.aaronjake commentedHi @aayushmankotia,
Applied patch #3, some of the files of the patch did not apply successfully, might be the reason the errors below was thrown.
Kindly check,
Jake
Comment #6
priyanka_chauhan31 commentedHi, I am working on this.
Comment #7
priyanka_chauhan31 commentedPlease review the patch. I have solved all the phpcs issues found.
Comment #10
ggh commentedMR Raised
Comment #11
hchonovThis needs a re-roll please.
Comment #13
kartikey gupta commentedComment #15
kartikey gupta commentedMR Raised