| Comment | File | Size | Author |
|---|---|---|---|
| #7 | phpcs_conding_standard-3372832-7.patch | 17.4 KB | priyanka_chauhan31 |
| #4 | fixed_issue_3372832-3.patch | 17.27 KB | aayushmankotia |
Issue fork config_track-3372832
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
satish_kumar commentedHello, @urvashi_vora thanks for the patch, I have applied your patch and ran successfully.
These are the steps I followed:
1. Took clone from git version 1.0.x in drupal 10.1.x
2. Ran this command:
3. Applied your patch and, again ran phpcs command
found errors
4. I have fixed that error with phpcbf.
Ran this command to fix the errors:
again ran phpcs command
found no errors.
Please review.
Comment #4
aayushmankotia commentedHi @Satish_kumar
I have created a patch to address all the PHP coding standard issues. Please review.
Comment #5
a.aaronjake commentedHi @aayushmankotia,
Applied patch #3, some of the files of the patch did not apply successfully, might be the reason the errors below was thrown.
Kindly check,
Jake
Comment #6
priyanka_chauhan31 commentedHi, I am working on this.
Comment #7
priyanka_chauhan31 commentedPlease review the patch. I have solved all the phpcs issues found.
Comment #10
ggh commentedMR Raised
Comment #11
hchonovThis needs a re-roll please.
Comment #13
kartikey gupta commentedComment #15
kartikey gupta commentedMR Raised