Problem/Motivation

When installing both google_analytics and google_tag, the ga module is no longer functional due to the google_tag_module_implements_alter hook unsetting the ga hook. This either should not be there, or there should be some support for the google analytics account number.

In the very least, this conflict needs to be much more widely communicated to the user on the edit form or present some type of message in the site "status report" page. There is no information on either module page indicating any problem installing both modules together.

Steps to reproduce

Proposed resolution

Remove the hook unset or support it in the google_tag.tag_container_resolver service.

Remaining tasks

User interface changes

API changes

Data model changes

Comments

pookmish created an issue. See original summary.

sean_fremouw’s picture

I assume there must have been some rationale for unsetting GA page attachments originally, so I don't know if removing that code is the best option, but here's a patch for 2.0.x branch that does that for anyone who needs it. Note that this patch will not work for latest release (2.0.2) because of change to a single comment in 2.0.x branch since 2.0.2.