Problem/Motivation

Adding both core and core_version_requirement with anything other than core_version_requirement: ^8 || ^9 || ^10 will result in an exception. This is not valid because the core: key would include versions that do not recognize the core_version_requirement: key.

Steps to reproduce

For example, a theme that is compatible with Drupal 8 versions after Drupal 8.8.0 and also Drupal 9 will need an info.yml file like this:

name: My Module
type: module
core_version_requirement: ^8 || ^9 || ^10

CommentFileSizeAuthor
#12 update-3370129.patch416 bytesharshita mehna
#6 after-patch.png75.37 KBpriya_degwekar
#6 before-patch.png74.34 KBpriya_degwekar
#5 Screenshot 2023-06-27 at 10.51.20 AM.png86.84 KBpriya_degwekar
#4 remove-core-key-3370129-2.patch371 bytesharshita mehna
Screenshot.png79.56 KBharshita mehna

Issue fork block_class-3370129

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Harshita mehna created an issue. See original summary.

Harshita mehna opened merge request !20

Harshita mehna closed merge request !20

harshita mehna’s picture

harshita mehna commented
Status: Active » Needs review
StatusFileSize
new remove-core-key-3370129-2.patch371 bytes

Hello Maintainers,
I have provided a patch to fix this issue.
To get more information visit https://www.drupal.org/node/3070687
Please review it.

Thanks!

priya_degwekar’s picture

priya_degwekar commented
StatusFileSize
new Screenshot 2023-06-27 at 10.51.20 AM.png86.84 KB

Verified and tested the #4 patch on 2.0.x , core key is removed cleanly. Added screenshot for reference.

Can be moved to RTBC+1.

priya_degwekar’s picture

priya_degwekar commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new before-patch.png74.34 KB
new after-patch.png75.37 KB
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: [Drupal 10] Do not allow core: 8.x in info.yml file. » Remove "core: 8.x" from the .info.yml file
Category: Bug report » Task
Priority: Normal » Minor
Status: Reviewed & tested by the community » Needs work 
configure: block_class.settings
-core: 8.x
 core_version_requirement: ^8 || ^9 || ^10

^8 must be replaced with ^8.8.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

As a side note, it is not helpful to show a screenshot as a prove the patch applies. The patch could apply, but the changes be wrong.
Also a screenshot that shows how the changed files become is not helpful and it is not a reason for changing the status to Reviewed & tested by the community. In fact, the changes done from the patch are wrong and the correct status should be Needs work.

Harshita mehna opened merge request !22

Harshita mehna closed merge request !22

Harshita mehna opened merge request !23

harshita mehna’s picture

harshita mehna commented
Status: Needs work » Needs review
StatusFileSize
new update-3370129.patch416 bytes

@apaderno, I have updated the patch update-3370129.patch please review.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

The last patch is correct.

renatog’s picture

renatog commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Novice, +Needs merge request

could someone create a MR based on #12, please?

sakthi_dev made their first commit to this issue’s fork.

bharath-kondeti made their first commit to this issue’s fork.

bharath-kondeti opened merge request !24

sakthi_dev opened merge request !25

sakthi_dev’s picture

sakthi_dev commented
Status: Needs work » Needs review

Updated composer as well. Please review.

renatog’s picture

renatog commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Novice, -Needs merge request

Thank you so much everyone

renatog’s picture

renatog commented
Status: Reviewed & tested by the community » Fixed

thanks everyone

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

dydave closed merge request !25

dydave closed merge request !23