Problem/Motivation

Single directory components (SDC) is a new way to theme Drupal. Instead of scattering related files around your theme, they're contained to one directory. The primary issue for SDC is at #3313520: Single directory components in core.

The Demo Umami team has decided that their theme can depend on an experimental module like SDC. This allows us to have the work in this ticket merged even when #3352256: [META] Move code from the experimental SDC module to core is not committed.

CommentFileSizeAuthor
Screenshot 2023-06-25 at 3.27.46 PM.png22.27 KBgauravvvv

Issue fork drupal-3369933

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Gauravvvv created an issue. See original summary.

Gauravvvv opened merge request !4261

gauravvvv’s picture

gauravvvv commented
Title: Create new SDC component for Umami (Seacg) » Create new SDC component for Umami (Seach)
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work
Issue tags: +Needs Review Queue Initiative

Testing MR 4261 and the icon is missing now.

gauravvvv’s picture

gauravvvv commented
Status: Needs work » Needs review
gauravvvv’s picture

gauravvvv commented
Title: Create new SDC component for Umami (Seach) » Create new SDC component for Umami (Search)
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Icon is back

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented
Status: Reviewed & tested by the community » Needs work

It feels like the feedback I have is the same I provided in https://www.drupal.org/project/drupal/issues/3368102#comment-15164102.

Please take a look at that to see if it's clear. If not, I will try to find the time to put it here as well.

gauravvvv’s picture

gauravvvv commented
Status: Needs work » Needs review

Addressed feedbacks of #8, please review

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Seems point 6 still needs to be addressed too.

snig’s picture

snig commented
Parent issue: » #3364673: [META] Create Single Directory Components for the Umami theme
snig’s picture

snig commented

I've moved comments back to the block template and the class definition to prevent their usage in the component template.

snig’s picture

snig commented
Status: Needs work » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Thanks @snig

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented
Status: Reviewed & tested by the community » Needs work

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.