Problem/Motivation

Forum topic markup is defined in PHP, not in a Twig template.

        $row[] = [
          'data' => [
            $topic->icon,
            [
              '#markup' => '<div class="forum__title"><div>' . $topic->title_link . '</div><div>' . $topic->submitted . '</div></div>',
            ],
          ],
          'class' => ['forum__topic'],
        ];

Steps to reproduce

Proposed resolution

Add a forum-topics.html.twig for the topics listup (/forum/x).

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork drupal-3368681

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

thomas.frobieter created an issue. See original summary.

larowlan’s picture

Project: Forum » Drupal core
Version: 1.x-dev » 11.x-dev
Component: Code » forum.module
Category: Task » Feature request

Forum is still in core (for now)
So moving there

elber made their first commit to this issue’s fork.

Abhijith S made their first commit to this issue’s fork.

abhijith s’s picture

Status: Active » Needs review
smustgrave’s picture

Priority: Normal » Minor
Status: Needs review » Reviewed & tested by the community

Seems like a minor enough change. Not sure if there is any test coverage needed.

larowlan’s picture

Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs change record

This looks good, can we get a change record to go with it?

Thanks!

nidhi27’s picture

Status: Needs work » Needs review
Issue tags: -Needs change record

I have added the change record Display forum title correctly using new template.
Kindly review this.

smustgrave’s picture

Status: Needs review » Reviewed & tested by the community

CR looks good.

larowlan’s picture

Updating credits.

Removing @elber as it appears that commits were just from clicking rebase in gitlab UI.

Crediting @Abhijith S as the original author, @nidhi27 for creating the change record and @thomas.frobieter for creating the issue

  • larowlan committed d6ac6d30 on 11.x authored by Abhijith S
    Issue #3368681 by larowlan, Abhijith S, thomas.frobieter, nidhi27:...
larowlan’s picture

Status: Reviewed & tested by the community » Fixed

Thanks folks, nice quick turnaround here

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.