FILE: D:\xampp\htdocs\drupal_10\web\modules\contrib\upgrade_status\src\Commands\UpgradeStatusCommands.php
---------------------------------------------------------------------------------------------------------
93 | WARNING | Unused variable $type.
149 | WARNING | Unused variable $type.
254 | WARNING | Unused variable $type.
---------------------------------------------------------------------------------------------------------

FILE: D:\xampp\htdocs\drupal_10\web\modules\contrib\upgrade_status\src\DeprecationAnalyzer.php
----------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
----------------------------------------------------------------------------------------------
436 | WARNING | Unused variable $path.
----------------------------------------------------------------------------------------------

FILE: D:\xampp\htdocs\drupal_10\web\modules\contrib\upgrade_status\src\Form\UpgradeStatusForm.php
----------------------------------------------------------------------------------------------------------------------------------
616 | WARNING | Unused variable $name.
1245 | WARNING | Unused variable $error.
1361 | WARNING | Unused variable $data.
1500 | WARNING | Unused variable $config.
1501 | WARNING | Unused variable $databases.
1502 | WARNING | Unused variable $class_loader.
-------------------------------------------------------------------------------------------------------------------------------------

FILE: D:\xampp\htdocs\drupal_10\web\modules\contrib\upgrade_status\src\LibraryDeprecationAnalyzer.php
-----------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------
347 | WARNING | Unused variable $type.
-----------------------------------------------------------------------------------------------------

CommentFileSizeAuthor
#5 3368554-5.patch4.81 KBmrinalini9
#2 3368554-2.patch4.76 KBarti_parmar

Issue fork upgrade_status-3368554

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

arti_parmar created an issue. See original summary.

arti_parmar’s picture

arti_parmar commented
Assigned: arti_parmar » Unassigned
Category: Task » Bug report
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new 3368554-2.patch4.76 KB

kindly review patch.

Status: Needs review » Needs work

The last submitted patch, 2: 3368554-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: Unused variable $type. » Remove the unused variables
Category: Bug report » Task
Priority: Normal » Minor 
-      list($error, $message, $data) = static::doHttpRequest('upgrade_status_request_test', 'upgrade_status_request_test');
+      list($message, $data) = static::doHttpRequest('upgrade_status_request_test', 'upgrade_status_request_test');
-            list($type, $value, $line) = $token;
+            list($value, $line) = $token;

The changed line is not equivalent to the existing one.

mrinalini9’s picture

mrinalini9 commented
Status: Needs work » Needs review
StatusFileSize
new 3368554-5.patch4.81 KB

Added patch to remove unused variables issues as mentioned in the issue description above, please review it.

Thanks!

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Needs work 
+++ b/src/Form/UpgradeStatusForm.php
@@ -1497,9 +1497,7 @@ MARKUP
-      $config = [];
-      $databases = [];
-      $class_loader = require $app_root . '/autoload.php';
+      require $app_root . '/autoload.php';
       require $app_root . '/' . $site_path . '/settings.php';

These are required to include the settings file and provide proper defaults, so we should not remove them.

akshay.singh made their first commit to this issue’s fork.

akshay.singh opened merge request !56

akshay.singh’s picture

akshay.singh commented
Status: Needs work » Needs review

point #6 addressed and MR created

Please review

Thanks

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Title: Remove the unused variables » Remove unused variables
Status: Needs review » Fixed

All right, committed this, thanks all!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.