Problem/Motivation

Single directory components (SDC) is a new way to theme Drupal. Instead of scattering related files around your theme, they're contained to one directory. The primary issue for SDC is at #3313520: Single directory components in core.

As part of SDC's roadmap (see #3345922: Single Directory Components module roadmap: the path to beta and stable), we want to convert an Umami component to use SDC. For this task I'm choosing the c footer promo component, which includes markup and CSS.

Testing instructions

  1. Make sure you have SDC module enabled, if enabling via drush si demo_umami it will be installed by the profile
  2. Clear caches
  3. Test footer promo - you should see HTML like the screenshot below showing that the cards are being rendered via a component
CommentFileSizeAuthor
#10 3367152-10.patch8.6 KBmrinalini9
#9 3367152-nr-bot.txt84 bytesneeds-review-queue-bot
#5 interdiff-2_5.txt367 bytesgauravvvv
#5 3367152-5.patch6.05 KBgauravvvv
#4 SDC-footer-promo-3367152-4.patch5.8 KBsakthi_dev
#2 3367152-2.patch5.69 KBgauravvvv

Comments

Gauravvvv created an issue. See original summary.

gauravvvv’s picture

gauravvvv commented
Status: Active » Needs review
StatusFileSize
new 3367152-2.patch5.69 KB

I have provided a patch to create footer promo block component. please review

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

For test failures.

sakthi_dev’s picture

sakthi_dev commented
StatusFileSize
new SDC-footer-promo-3367152-4.patch5.8 KB
gauravvvv’s picture

gauravvvv commented
Status: Needs work » Needs review
StatusFileSize
new 3367152-5.patch6.05 KB
new interdiff-2_5.txt367 bytes

Fixed test failure. Attached interdiff for same. please review

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work
Issue tags: +Needs issue summary update

Can the issue summary be updated as it references card view mode but that's not this ticket.

gauravvvv’s picture

gauravvvv commented
Issue summary: View changes
Status: Needs work » Needs review

Updated issue summary

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs issue summary update +Needs Review Queue Initiative

Verified on Umami that the promo is unchanged.

needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Reviewed & tested by the community » Needs work
StatusFileSize
new 3367152-nr-bot.txt84 bytes

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

mrinalini9’s picture

mrinalini9 commented
Status: Needs work » Needs review
StatusFileSize
new 3367152-10.patch8.6 KB

Rerolled patch #5, please review it.

Thanks & Regards,
Mrinalini

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Can you please provide an interdiff + explanation for the additional changes?

Also not sure it should be moving things to demo_umami/components. See the theme folder, it has a components there.

finnsky’s picture

finnsky commented
Status: Needs work » Needs review

Added common footer component for both blocks here:
https://www.drupal.org/project/drupal/issues/3368102#comment-15215846

smustgrave’s picture

smustgrave commented

@finnsky are you saying you moved over work to another ticket? Should this be closed then.

finnsky’s picture

finnsky commented

RE: #13

I think that this is one component. I added both in linked issue.

smustgrave’s picture

smustgrave commented
Status: Needs review » Closed (duplicate)

Will move over credit.