FILE: D:\xampp\htdocs\drupal_10\web\modules\contrib\eu-cookie-compliance\src\EventSubscriber\EuCookieComplianceConfigEventsSubscriber.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
-----------------------------------------------------------------------------------------------------------------------------------------
50 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
59 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
64 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-----------------------------------------------------------------------------------------------------------------------------------------
FILE: D:\xampp\htdocs\drupal_10\web\modules\contrib\eu-cookie-compliance\src\Plugin\Block\CookieSettingsButtonBlock.php
-----------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------
31 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-----------------------------------------------------------------------------------------------------------------------
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | diff.txt | 2.71 KB | keshavv |
| #3 | 3366721-3.patch | 6.23 KB | keshavv |
| #2 | 3366721-2.patch | 5.38 KB | arti_parmar |
| #2 | 3366721-2.patch | 5.38 KB | arti_parmar |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes, plain diff MR !128changes, plain diff MR !127
Comments
Comment #2
arti_parmar commentedkindly review patch.
Comment #3
keshavv commentedHi, @arti_parmar
Thank you for the patch. But it is incomplete.
I have created the one, Please review it. Also added the diff.
Please review
Thank you.
Comment #4
keshavv commentedPlease ignore the above diff. Added a new one.
Comment #5
svenryen commentedI made a small change to satisfy code styling.
Comment #7
svenryen commentedComment #9
svenryen commentedI have to reopen this one, as file.repository isn't available before Drupal 9, and we need this module to also support Drupal 8.
Since we have a code base that will work in Drupal 8, and there are a large number of sites out there on Drupal 8, I'd rather support Drupal 8 than blocking it due to a missing service.
Comment #10
svenryen commentedComment #14
svenryen commentedI fixed the d8 compatibility issue.
Here's the patch:
https://git.drupalcode.org/project/eu-cookie-compliance/-/merge_requests...