Problem/Motivation

The config translation UI opens forms that are pretty simple in their layout; there's original text on the left and form to provide translations on the right. When you're taken on this page, it's a slightly confusing experience because there are no local tasks that would indicate where you currently located, leaving breadcrumb as the only indication of the location of the page.

Proposed resolution

We could solve this problem by opening the config translation add and edit forms in a modal dialog.

Remaining tasks

User interface changes

Before:

After:

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3366676-2.patch5.09 KBlauriii
#2 drupal-dev.ddev_.site_en_admin_structure_types_manage_article_translate.png128.39 KBlauriii
#2 drupal-dev.ddev_.site_en_admin_structure_types_manage_article_translate_es_edit.png96.99 KBlauriii

Issue fork drupal-3366676

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

lauriii created an issue. See original summary.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new drupal-dev.ddev_.site_en_admin_structure_types_manage_article_translate_es_edit.png96.99 KB
new drupal-dev.ddev_.site_en_admin_structure_types_manage_article_translate.png128.39 KB
new 3366676-2.patch5.09 KB
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs Review Queue Initiative

Tested out on 11.x following the screenshots in the issue summary.
Confirmed the translate modal popups as described. Looks good

narendrar’s picture

narendrar
He/Him
Primary language English
Location Jaipur, India
commented

Found a small nit.

+++ b/core/modules/config_translation/tests/src/FunctionalJavascript/ConfigTranslationUiTest.php
@@ -43,4 +44,35 @@ public function testViewContextualLink() {
+   * Tests that config translation add and edit operation opens in a modal.

add and edit ==> add, edit and delete

rajeshreeputra’s picture

rajeshreeputra
he/him
Location Pune
commented

@lauriii, @smustgrave tested the patch on 11.x this gives really good feel while translation. My question here is why not to include it in D10.1.x?

Ahmad Smhan made their first commit to this issue’s fork.

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented

Re #5 @Rajeshreeputra:

e tested the patch on 11.x this gives really good feel while translation. My question here is why not to include it in D10.1.x?

Unless a change is meant only for a specific branch, we work on the highest-numbered dev branch first, then backport to earlier versions. So in this case we are working on 11.x, and when it is committed to 11.x it will also be backported to the 10.x dev branch(es) permitted by the backport policy

  • bnjmnm committed d3a1923f on 11.x 
    Issue #3366676 by lauriii, smustgrave, narendraR: Display config...
bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Version: 11.x-dev » 10.1.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Good improvement!

Committed to 11.x and added the suggestion in #4 before doing so.

This should get backported to 10, but since it is 10.1 release day I'm going to wait until post release to determine which additional branch(es) get it.

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Status: Patch (to be ported) » Fixed

Just got confirmation that 10.2 will be cut from 11.x so there's no need to backport. 10.1 is all but released, and this is the sort of change that isn't suitable for a patch release, so this is already complete.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.