Problem/Motivation

Drupal 10 compatibility

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 html_titles_compitible10.x-3366554-2.patch1.54 KByash_khandelwal

Issue fork html_titles-3366554

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

i-trokhanenko created an issue. See original summary.

yash_khandelwal’s picture

yash_khandelwal
Primary language English
commented
StatusFileSize
new html_titles_compitible10.x-3366554-2.patch1.54 KB

Hello,

Please review and apply the attached patch to make 10.x compatibility.

Thanks

yash_khandelwal’s picture

yash_khandelwal
Primary language English
commented
Status: Active » Needs review
i-trokhanenko’s picture

i-trokhanenko
Location Lutsk 🇺🇦
commented
Assigned: i-trokhanenko » Unassigned
Status: Needs review » Needs work

@ thanks, we also need to add the ^10 core_version_requirement in the .info.yml and composer.json

shivam_tiwari’s picture

shivam_tiwari commented
Assigned: Unassigned » shivam_tiwari

shivam_tiwari opened merge request !1

shivam_tiwari’s picture

shivam_tiwari commented
Assigned: shivam_tiwari » Unassigned
Status: Needs work » Needs review
i-trokhanenko’s picture

i-trokhanenko
Location Lutsk 🇺🇦
commented
Status: Needs review » Reviewed & tested by the community

Looks good to me, thanks @shivam_tiwari

i-trokhanenko’s picture

i-trokhanenko
Location Lutsk 🇺🇦
commented
Status: Reviewed & tested by the community » Fixed

Thanks!

tjtj’s picture

tjtj commented

Crashed. D10.1.0
Error: Non-static method
Drupal\Core\Extension\ExtensionPathResolver::getPath()
cannot be called statically in
html_titles_theme_registry_alter() (line 24 of
/home/orcmaorg/public_html/web

i-trokhanenko’s picture

i-trokhanenko
Location Lutsk 🇺🇦
commented
Status: Fixed » Needs work
i-trokhanenko’s picture

i-trokhanenko
Location Lutsk 🇺🇦
commented
Assigned: Unassigned » i-trokhanenko

i-trokhanenko opened merge request !2

i-trokhanenko’s picture

i-trokhanenko
Location Lutsk 🇺🇦
commented
Assigned: i-trokhanenko » Unassigned
Status: Needs work » Fixed

Fixed the error and created a new version of the module - https://www.drupal.org/project/html_titles/releases/8.x-1.1

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.