Olivero's RSS Feed icon component should be migrated to single directory components. The file to start with is core/themes/olivero/templates/misc/feed-icon.html.twig.

CommentFileSizeAuthor
Demonstration_of_non-media_image_embeds___Olivero-2.png106.2 KBmherchel

Issue fork drupal-3365481

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mherchel created an issue. See original summary.

dharizza made their first commit to this issue’s fork.

dharizza opened merge request !4125

dharizza’s picture

dharizza commented
Version: 11.x-dev » 10.1.x-dev
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work
Issue tags: +Needs Review Queue Initiative

Seems there were some failures in the MR.

Have not yet tested.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented

When I test this out, I'm getting 

Drupal\sdc\Exception\InvalidComponentException: Unable to find class/interface "url" specified in the prop "url" for the component "olivero:feed-icon". in Drupal\sdc\Component\ComponentValidator->validateDefinition() (line 118 of core/modules/sdc/src/Component/ComponentValidator.php).

Going to look into it a bit now (if I have time)

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented

Just left some comments. In addition, we need to copy over the feed.pcss.css file. Both the pcss.css and css files should also be renamed to whatever the component is (in this case "feed").

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Issue tags: +SDC Sprint DrupalConNA 2023

Starting to look good! Left some more comments in the MR.

Gauravvvv made their first commit to this issue’s fork.

gauravvvv’s picture

gauravvvv commented
Status: Needs work » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Postponed

Postponing until SDC is marked stable.

finnsky’s picture

finnsky commented
Status: Postponed » Needs work

Maybe name this component `icon-text` and make svg icon configurable?
This is component and it planned to be reusable. Even if used in one place only?

finnsky’s picture

finnsky commented

Reworked with this described ^ approach.

Common `icon-link` component with configurable icon.

finnsky’s picture

finnsky commented
Status: Needs work » Needs review

finnsky opened merge request !4697

finnsky’s picture

finnsky commented
Status: Needs review » Postponed

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

finnsky’s picture

finnsky commented
Status: Postponed » Needs review
finnsky’s picture

finnsky commented
Status: Needs review » Needs work

We need to fix linter and fix schema version in component.yaml

gauravvvv’s picture

gauravvvv commented
Status: Needs work » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Have not reviewed yet

Appears to have test failures.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.