[4.0.x] Social auth nextcloud

Thank you for applying! Reviewers will review the project files, describing what needs to be changed.

Please read Review process for security advisory coverage: What to expect for more details and Security advisory coverage application checklist to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smoother review.

To reviewers: Please read How to review security advisory coverage applications, What to cover in an application review, and Drupal.org security advisory coverage application workflow.

While this application is open, only the user who opened the application can make commits to the project used for the application.

Reviewers only describe what needs to be changed; they don't provide patches to fix what reported in a review.

Please fix PHPCS issues

FILE: /social_auth_nextcloud/README.md
---------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
---------------------------------------------------------------------------
 65 | WARNING | Line exceeds 80 characters; contains 93 characters
 90 | WARNING | Line exceeds 80 characters; contains 83 characters
---------------------------------------------------------------------------


FILE: /social_auth_nextcloud/src/Plugin/Network/NextcloudAuth.php
------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------
 28 | WARNING | Line exceeds 80 characters; contains 81 characters
------------------------------------------------------------------------------------------------------


FILE: /social_auth_nextcloud/social_auth_nextcloud.routing.yml
---------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------
 11 | ERROR | [x] Expected 1 newline at end of file; 2 found
---------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------

That's fine @aleix
Ran PHPCS tests. No other issues found! Lets wait for other reviewers.

@aleix , I have reviewed the changes, and they look fine to me.

Let’s wait for other reviewers to take a look and if everything goes fine, you will get the role.

Automated Review

FILE: /var/www/html/web/modules/contrib/social_auth_nextcloud/tests/src/Functional/SocialAuthNextcloudTestBase.php
------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Url.
------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/web/modules/contrib/social_auth_nextcloud/src/Plugin/Derivative/NextcloudInstance.php
----------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Component\Plugin\Derivative\DeriverBase.
----------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/web/modules/contrib/social_auth_nextcloud/src/Plugin/Derivative/DynamicLocalTasks.php
----------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Component\Plugin\Derivative\DeriverBase.
----------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/web/modules/contrib/social_auth_nextcloud/src/Plugin/Network/NextcloudAuth.php
--------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------
 28 | WARNING | Line exceeds 80 characters; contains 81 characters
--------------------------------------------------------------------------------------------------

Manual Review

1. Comments for Exception Catching: Include comments explaining why you're catching specific exceptions. This provides context for future maintainers. For example:
   

   try {
       // Attempt to set the access token.
       $this->setAccessToken($this->client->getAccessToken('authorization_code', ['code' => $this->request->query->get('code')]));
     } catch (IdentityProviderException $e) {
       // Log an error message in case of an exception.
       $this->loggerFactory->get('social_auth_nextcloud')
         ->error('There was an error during authentication. Exception: ' . $e->getMessage());
     }

2. Consistent Naming Convention: Keep your naming convention consistent. For instance, $configFactory is using camelCase, but other variables like $extra_scopes and $request_stack are using snake_case. Stick to one convention for variable naming throughout your codebase.
3. Use Constants for Static values: Define static values like 'v2-federated' as constants to avoid duplication and provide reusability in the future.

FILE: social_auth_nextcloud.routing.yml

_permission: 'administer social api authentication'

'administer social api authentication' permission is not defined in the module.

@vishal.kadam, based on my understanding, this module relies on the social_auth module, which utilizes the administer social api authentication permission. Therefore, if the permission needs to be defined, it should be done through the social_auth module. However, note that my interpretation may not be entirely accurate.

@Hemangi Gokhale Thanks for pointing it out.

This module relies on the social_auth module, which relies on the social_api module, where 'administer social api authentication' permission is defined.

So comment #10 is invalid, and there is no need to change anything.

Cool, but @vishal.kadam, I think this module still needs work as per the review done at #9

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the Slack #contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the reviewers.