I don't know how to reproduce it, but from time to time error

Error: Call to a member function getTranslationLanguages() on null in Drupal\node_revision_delete\Plugin\QueueWorker\NodeRevisionDelete->processItem() (line 83 of /app/web/modules/contrib/node_revision_delete/src/Plugin/QueueWorker/NodeRevisionDelete.php)

Issue fork node_revision_delete-3363362

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

goodDenis created an issue. See original summary.

goodDenis opened merge request !21

gooddenis’s picture

gooddenis commented
Assigned: gooddenis » Unassigned
Status: Active » Needs review
rp7’s picture

rp7 commented

Looks like this is already being fixed in #3380623: Revisions not deleted when revision_translation_affected is NULL for all languages?

adriancid’s picture

adriancid
Primary language Spanish
Location Qc, Canada 🇨🇦
commented
Status: Needs review » Closed (duplicate)
Related issues: +#3380623: Revisions not deleted when revision_translation_affected is NULL for all languages
eduardo morales alberti’s picture

eduardo morales alberti
Primary language Spanish
Location Spain, 🇪🇺
commented
Status: Closed (duplicate) » Needs work

It is unrelated to #3380623: Revisions not deleted when revision_translation_affected is NULL for all languages because the question here is to check if the revision is a valid object, it fails on a different line.

We should check if the revision is a valid node before calling to get the translation method, because if the revision is null it gives the reported error.

eduardo morales alberti opened merge request !30

eduardo morales alberti closed merge request !30

eduardo morales alberti’s picture

eduardo morales alberti
Primary language Spanish
Location Spain, 🇪🇺
commented
Status: Needs work » Needs review

Do not process the revision if is not node.

rcodina’s picture

rcodina
Primary language Catalan
Location Barcelona
commented

I confirm that after applying patch from MR21 the error is gone. Thanks!

alexpott made their first commit to this issue’s fork.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • alexpott committed b4be7773 on 2.0.x 
    fix: #3363362 Error: Call to a member function getTranslationLanguages...

  • alexpott committed 6d941466 on 2.1.x 
    fix: #3363362 Error: Call to a member function getTranslationLanguages...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.