Problem/Motivation

Checking the 'Structure -> Block layout' page, it has been observed that the theming of the weight field (select box) is inconsistent compared to the other tables views fields, it should be the same as region field style (select box).
This discrepancy has been tested on versions 9.x, 10.x, and 11.x of the core.

Steps to reproduce

  1. Drupal 10.0.x and set the claro theme as admin theme
  2. admin/structure/block/list/claro on path click on show row weights button
  3. check the weight field (styling is different from other field).
CommentFileSizeAuthor
#12 3362924-12.patch4.09 KBfrank8199
#11 interdiff_8-10.txt4.09 KBfrank8199
#11 3362924-10.patch4.08 KBfrank8199
#9 3362924 after patch8 applied .png87.48 KBHarish1688
#8 interdiff-6_8.txt5.3 KBgauravvvv
#8 3362924-8.patch3.37 KBgauravvvv
#7 3362924 - after patch impact on text field theme .png43.57 KBHarish1688
#7 3362924 - after patch impact on select box on magage field .png83.19 KBHarish1688
#6 3362924-6.patch2.5 KBgauravvvv
#6 interdiff-4_6.txt2.32 KBgauravvvv
#3 15078817.patch707 bytesshwetaDevkate
issue - An inconsistency in the theming of the weight field image copy.png112.2 KBHarish1688

Issue fork drupal-3362924

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Harish1688 created an issue. See original summary.

shwetaDevkate’s picture

shwetaDevkate commented
Assigned: Unassigned » shwetaDevkate
shwetaDevkate’s picture

shwetaDevkate commented
StatusFileSize
new 15078817.patch707 bytes

Patch attached. please review.

shwetaDevkate’s picture

shwetaDevkate commented
Assigned: shwetaDevkate » Unassigned
cilefen’s picture

cilefen commented
Title: An inconsistency has been identified in the theming of the weight field on the Structure Block layout page. » The weight field on the block layout is formatted differently from similar fields
Status: Active » Needs work

There is a comment in the diff that says “iOS”, which doesn’t really convey information and also this issue doesn’t mention specific browsers or platforms.

gauravvvv’s picture

gauravvvv commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-4_6.txt2.32 KB
new 3362924-6.patch2.5 KB

I have attached a patch and added the interdiff with #4. It was not just about padding property, the other properties like font-size, line-height and min-height were not same that's why styling was inconsistent. I have added all of them. please review

Harish1688’s picture

Harish1688 commented
Status: Needs review » Needs work
StatusFileSize
new 3362924 - after patch impact on select box on magage field .png83.19 KB
new 3362924 - after patch impact on text field theme .png43.57 KB

Hi @Gauravvvv,

I thoroughly tested patch #6 and verified it functions correctly, successfully resolving the issue on popular browsers including Chrome, Safari, and Mozilla. However, it has inadvertently affected all text fields (input text, select box) styling throughout the claro theme, may be it should be limited only block layout page.

check patch impact on path:
admin/structure/types/manage/article
admin/structure/types/manage/article/form-display
images attached for references :

gauravvvv’s picture

gauravvvv commented
Status: Needs work » Needs review
StatusFileSize
new 3362924-8.patch3.37 KB
new interdiff-6_8.txt5.3 KB

I have fixed the issue and attached interdiff with #6. please review

Harish1688’s picture

Harish1688 commented
StatusFileSize
new 3362924 after patch8 applied .png87.48 KB

Hi @Gauravvvv,

I thoroughly tested (3362924-8.patch) and verified that it functions correctly, successfully resolving the issue on 'Structure -> Block layout' ,
but, it has inadvertently affected on path 'admin/structure/types/manage/article/form-display' (weight filed) styling. it should be theme like other sibling field.

frank8199 made their first commit to this issue’s fork.

frank8199’s picture

frank8199 commented
StatusFileSize
new 3362924-10.patch4.08 KB
new interdiff_8-10.txt4.09 KB

I have attached a patch and added the interdiff with #8.

In order to keep consistency across different pages decided to NOT apply the modifier `extrasmall` to form select and form text elements.

Tested on following pages:

  1. /admin/content
  2. /admin/structure/types/manage/article/display
  3. /admin/structure/block
  4. /admin/structure/taxonomy/manage/tags/overview
  5. /admin/structure/menu/manage/admin
  6. /admin/people/roles
frank8199’s picture

frank8199 commented
StatusFileSize
new 3362924-12.patch4.09 KB

Re-rolling patch #11 as it fails to apply.

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work
Issue tags: +Needs Review Queue Initiative, +Needs tests

As a bug it could use a test case.

frank8199 opened merge request !4089

frank8199 opened merge request !4090

frank8199 closed merge request !4090

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

quietone’s picture

quietone commented
Status: Needs work » Postponed

The Claro theme was approved for removal in #3576460: [policy, no patch] Deprecate and remove Claro.

This is Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project and the Extensions approved for removal policies.

The deprecation work is in #3576668: [meta] Tasks to deprecate Claro and the removal work in #3584638: [meta] Tasks to remove the Claro theme.