Problem/Motivation

In #3123832: [META] Fix @todo items referencing closed issues we've discovered there's a @todo in core/themes/claro/css/components/views-ui.pcss.css and core/themes/claro/css/components/views-ui.css.
This @todo is linked to an d.o. issue that is already closed: #3135457: Select widths not taken into account when table is rendered.

This is the @todo:

/**
 * Elements must communicate width to table rendering.
 * @todo revisit in https://drupal.org/node/3135457
 */

Proposed resolution

#3135457: Select widths not taken into account when table is rendered was closed as a duplicate of #3159896: Select form field values are hidden at narrow screen widths in Claro theme.
That issue has been fixed and by the looks of it, it has resolved the issue described in #3135457: Select widths not taken into account when table is rendered:

Steps to reproduce from #3135457: Select widths not taken into account when table is rendered

Go to en/admin/structure/types/manage/page/display
Click "show row weights" if they're not already being shown.
Narrow the viewport until you see this thing:

If I try to reproduce the issue with the above steps, I end up with a horizontal scrollbar and fully visible select fields as per the described solution in #3159896: Select form field values are hidden at narrow screen widths in Claro theme.

Proposed resolution from #3159896: Select form field values are hidden at narrow screen widths in Claro theme

Update the CSS to ensure select fields are always visible in forms by adding a horizontal scroll:

Let's remove both @todos as they seem no longer relevant.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 2023-05-19_12-58-23.jpg50.35 KBspokje

Issue fork drupal-3361465

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Spokje created an issue. See original summary.

spokje’s picture

Issue summary: View changes
StatusFileSize
new50.35 KB
spokje’s picture

Issue summary: View changes

spokje’s picture

Status: Active » Needs review
borisson_’s picture

Status: Needs review » Reviewed & tested by the community

LGTM.

schillerm’s picture

Status: Reviewed & tested by the community » Needs review

Also checked this.. seems fine

spokje’s picture

Status: Needs review » Reviewed & tested by the community

Thanks for checking, I assume it can stay RTBC

longwave’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed b7c4aaf2e0 to 11.x (10.2.x) and 909004bf83 to 10.1.x and 142cdff033 to 10.0.x and 736cef91a2 to 9.5.x. Thanks!

  • longwave committed 142cdff0 on 10.0.x
    Issue #3361465 by Spokje: Remove outdated @todo's pointing to #3135457...

  • longwave committed 909004bf on 10.1.x
    Issue #3361465 by Spokje: Remove outdated @todo's pointing to #3135457...

  • longwave committed b7c4aaf2 on 11.x
    Issue #3361465 by Spokje: Remove outdated @todo's pointing to #3135457
    

  • longwave committed 736cef91 on 9.5.x
    Issue #3361465 by Spokje: Remove outdated @todo's pointing to #3135457...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.