The tests are currently failing because of a missing schema definition, e.g. https://www.drupal.org/pift-ci-job/2649110:

1) Drupal\Tests\lingotek\Functional\Actions\LingotekActionsTest::testActionsCreatedWhenEnablingTranslations
Drupal\Core\Config\Schema\SchemaIncompleteException: Schema errors for lingotek.account with the following errors: lingotek.account:new_registeration_landing missing schema

Comments

DamienMcKenna created an issue. See original summary.

damienmckenna’s picture

Status: Active » Needs review
StatusFileSize
new407 bytes

This should cover it.

damienmckenna’s picture

Title: Test failures because of missing » Test failures because of missing schema definition
Issue summary: View changes

Status: Needs review » Needs work

The last submitted patch, 2: lingotek-n3361327-2.patch, failed testing. View results

damienmckenna’s picture

Title: Test failures because of missing schema definition » Fix test failures in 4.0.x (missing schema definition, etc)

That's good - it's down from 321 failures to only 31.

npaudyal001’s picture

StatusFileSize
new8.39 KB
npaudyal001’s picture

StatusFileSize
new8.39 KB
npaudyal001’s picture

StatusFileSize
new17.99 KB
damienmckenna’s picture

Down to 19! Nice!

npaudyal001’s picture

StatusFileSize
new2.62 KB

Adding the fix for drupal CI issue on 4.0.x here

  • npaudyal001 authored ce7aeefe on 4.0.x
    Issue #3361327 by npaudyal001, DamienMcKenna: Fix test failures in 4.0.x...

  • npaudyal001 authored 7a19e23d on 4.0.x
    Issue #3361327 by npaudyal001, DamienMcKenna: Fix test failures in 4.0.x...
npaudyal001’s picture

Resetting the previous commit since we got some fatal errors instead

murrow’s picture

A couple of questions here that might help me contribute a little better than I have been.

These tests are required for D10 (so PHP 8.1). This ticket appears to be for D9.5, but it is a blocker for #3288313. And there is also #3344857 that seems to cover this issue + a number of other test-related errors. D9.5 is EOL on 1 November. We also appear to have a D10 build issue that doesn't seem to be resolved in any of these tickets and relates to the composer permissions afforded the cweagans patch library.

My first question is, what is a plan of attack to get Lingotek to D10?

My second question is, given that there are roughly 7,000 phpstan errors thrown up on my D10 build (using Drupal check) on the tests alone and just 19 being thrown for the D9.5 build above and the matter of D9.5 EOL, is it meaningful putting effort into D9.5 at all?

Probably, I am missing something/a whole lot – apologies in advance.

damienmckenna’s picture

Trying to fix the build on 9.5 will mean there's a cleaner slate to work from for D10, so that on the D10 issue it'll be easier to tell whether test failures are because of the D10 changes or an existing bug.

npaudyal001’s picture

StatusFileSize
new31.12 KB
npaudyal001’s picture

With #16, 100% tests are passing on my local, not sure whats the deal with "Composer Config Failure"

damienmckenna’s picture

Sounds like an infrastructure problem.

damienmckenna’s picture

The composer problems have been fixed elsewhere, the latest patch now just has five errors.

damienmckenna’s picture

Is this redundant now?

murrow’s picture

Yes, I believe that this was covered in #3288313. @npaudyal001, could you confirm and then close this issue please?

damienmckenna’s picture

I think if you're going to list the 4.0.x branch as still maintained then the tests should still be fixed. On the other hand, if you're going to mark the 4.0.x branch unsupported then this could be closed.

npaudyal001’s picture

StatusFileSize
new34.02 KB
npaudyal001’s picture

StatusFileSize
new34.85 KB

  • npaudyal001 authored fd7d004c on 4.0.x
    Issue #3361327 by npaudyal001, DamienMcKenna, murrow: Fix test failures...
npaudyal001’s picture

Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.