The tests are currently failing because of a missing schema definition, e.g. https://www.drupal.org/pift-ci-job/2649110:
1) Drupal\Tests\lingotek\Functional\Actions\LingotekActionsTest::testActionsCreatedWhenEnablingTranslations
Drupal\Core\Config\Schema\SchemaIncompleteException: Schema errors for lingotek.account with the following errors: lingotek.account:new_registeration_landing missing schema
| Comment | File | Size | Author |
|---|---|---|---|
| #24 | lingotek-n3661327-24.patch | 34.85 KB | npaudyal001 |
| #23 | lingotek-n3661327-23.patch | 34.02 KB | npaudyal001 |
| #16 | lingotek-n3661327-16.patch | 31.12 KB | npaudyal001 |
| #10 | composer_issue_fix.patch | 2.62 KB | npaudyal001 |
| #8 | lingotek-n3661327-8.patch | 17.99 KB | npaudyal001 |
Comments
Comment #2
damienmckennaThis should cover it.
Comment #3
damienmckennaComment #5
damienmckennaThat's good - it's down from 321 failures to only 31.
Comment #6
npaudyal001 commentedComment #7
npaudyal001 commentedComment #8
npaudyal001 commentedComment #9
damienmckennaDown to 19! Nice!
Comment #10
npaudyal001 commentedAdding the fix for drupal CI issue on 4.0.x here
Comment #13
npaudyal001 commentedResetting the previous commit since we got some fatal errors instead
Comment #14
murrow commentedA couple of questions here that might help me contribute a little better than I have been.
These tests are required for D10 (so PHP 8.1). This ticket appears to be for D9.5, but it is a blocker for #3288313. And there is also #3344857 that seems to cover this issue + a number of other test-related errors. D9.5 is EOL on 1 November. We also appear to have a D10 build issue that doesn't seem to be resolved in any of these tickets and relates to the composer permissions afforded the cweagans patch library.
My first question is, what is a plan of attack to get Lingotek to D10?
My second question is, given that there are roughly 7,000 phpstan errors thrown up on my D10 build (using Drupal check) on the tests alone and just 19 being thrown for the D9.5 build above and the matter of D9.5 EOL, is it meaningful putting effort into D9.5 at all?
Probably, I am missing something/a whole lot – apologies in advance.
Comment #15
damienmckennaTrying to fix the build on 9.5 will mean there's a cleaner slate to work from for D10, so that on the D10 issue it'll be easier to tell whether test failures are because of the D10 changes or an existing bug.
Comment #16
npaudyal001 commentedComment #17
npaudyal001 commentedWith #16, 100% tests are passing on my local, not sure whats the deal with "Composer Config Failure"
Comment #18
damienmckennaSounds like an infrastructure problem.
Comment #19
damienmckennaThe composer problems have been fixed elsewhere, the latest patch now just has five errors.
Comment #20
damienmckennaIs this redundant now?
Comment #21
murrow commentedYes, I believe that this was covered in #3288313. @npaudyal001, could you confirm and then close this issue please?
Comment #22
damienmckennaI think if you're going to list the 4.0.x branch as still maintained then the tests should still be fixed. On the other hand, if you're going to mark the 4.0.x branch unsupported then this could be closed.
Comment #23
npaudyal001 commentedComment #24
npaudyal001 commentedComment #26
npaudyal001 commented