Closed (fixed)
Project:
Scheduler
Version:
2.0.0-rc8
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
3 May 2023 at 07:57 UTC
Updated:
7 Jul 2023 at 12:10 UTC
Jump to comment: Most recent
PHP deprecation notice:
PHP Deprecated: a:5:{s:11:"deprecation";s:119:"Creation of dynamic property Drupal\Tests\scheduler\Functional\SchedulerViewsAccessTest::$schedulerEditor is deprecated";s:5:"class";s:58:"Drupal\Tests\scheduler\Functional\SchedulerViewsAccessTest";s:6:"method";s:32:"testViewScheduledContentOverview";s:15:"triggering_file";s:123:"/home/runner/work/acquia_cms/orca-build/docroot/modules/contrib/scheduler/tests/src/Functional/SchedulerViewsAccessTest.php";s:11:"files_stack";a:8:{i:0;s:123:"/home/runner/work/acquia_cms/orca-build/docroot/modules/contrib/scheduler/tests/src/Functional/SchedulerViewsAccessTest.php";i:1;s:123:"/home/runner/work/acquia_cms/orca-build/docroot/modules/contrib/scheduler/tests/src/Functional/SchedulerViewsAccessTest.php";i:2;s:77:"/home/runner/work/acquia_cms/orca-build/docroot/sites/simpletest/TestCase.php";i:3;s:77:"/home/runner/work/acquia_cms/orca-build/docroot/sites/simpletest/TestCase.php";i:4;s:91:"/home/runner/work/acquia_cms/orca-build/vendor/phpunit/phpunit/src/Framework/TestResult.php";i:5;s:77:"/home/runner/work/acquia_cms/orca-build/docroot/sites/simpletest/TestCase.php";i:6;s:19:"Standard input code";i:7;s:19:"Standard input code";}} in /home/runner/work/acquia_cms/orca-build/vendor/symfony/phpunit-bridge/Legacy/SymfonyTestsListenerTrait.php on line 284
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #4
jonathan1055 commentedThanks for this. Can you run the tests at PHP8.2 to show that this fixes the warning.
Comment #5
vishalkhode commentedHi @Rajeshreeputra
Looks like there are more deprecations. Ex:
Comment #6
rajeshreeputrain devel module need to update the DevelGenerateRoutes file to fix below error.
include this code:
Comment #7
rajeshreeputraComment #8
ankitv18 commentedComment #9
rajeshreeputraThe SchedulerDevelGenerateTest test is failing because of the devel(devel_generate) module. @jonathan1055 could you update the DevelGenerateRoutes file with below change.
Above change fix below error and tests will be green.
include this code:
Comment #10
jonathan1055 commented@Rajeshreeputra The change you suggest is close but not exactly correct. However there is already a Devel Generate issue regarding this
https://gitlab.com/drupalspoons/devel/-/issues/468
Please do not cross-post requests for one module on another module's issue queue. It might be just a conincidence that I am maintainer of both. Use the Devel issue queue for Devel issues :-)
Comment #12
jonathan1055 commentedThe fix to Devl 5.x dev has been commited, see https://gitlab.com/drupalspoons/devel/-/merge_requests/152
This is only in the -dev version but I have made a change to Scheduer's drupalci.yml to get Devel 5.x-dev when running with PHP version 8.2 (see commit above).
So you can now rebase your MR and the DevelGenerate test should pass with PHP8.2
Comment #13
ankitv18 commentedMR!85 applied cleanly and passing with stable and next version of Drupal with PHP 8.1 and 8.2, hence moving into RTBC.
Comment #14
rajeshreeputrasure, @jonathan1055 will do. Thank you!!
Comment #15
jonathan1055 commentedThanks, it's looking good.
Now that I have opted in Scheduler for GitLab-CI testing I have now triggered a pipeline test (currently only project maintainers can do this). It is running on php8.1 so I may update that to php8.2
Comment #16
jonathan1055 commentedI have made a couple of improvements
Comment #18
jonathan1055 commentedThank you Rajeshreeputra, vishalkhode and ankitv18. Committed to 2.x.
This should also be done in 8.x-1.x I think.
Comment #21
jonathan1055 commentedNow fixed in 8.x-1.x
Thank you to everyone above who helped on this.
Comment #23
rajeshreeputra@jonathan1055 when can we expect release for the same.
Comment #24
jonathan1055 commentedHi Rajeshreeputra,
I have just committed the fix to the final 2.0 blocker #3336108: Don't run hook_modules_installed during config install and released Scheduler 2.0.0