Problem/Motivation

When something fails performing a backup it would be useful if there was some logging on what happened.

Steps to reproduce

Perform a backup via Drush, wait for it to fail, note that no useful explanation is provided and nothing is logged.

Proposed resolution

Add logging when something fails during a backup.

Remaining tasks

Add logging when something fails during a backup.

User interface changes

Something is logged or displayed when a backup fails.

API changes

TBD

Data model changes

TBD

CommentFileSizeAuthor
#3 backup_migrate-n3357349-3.patch934 bytesdamienmckenna

Issue fork backup_migrate-3357349

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

DamienMcKenna created an issue. See original summary.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Priority: Normal » Major

This is kinda important.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs review
StatusFileSize
new backup_migrate-n3357349-3.patch934 bytes

I'm not sure where the best place is to put this? Should we add a new plugin ala Notify.php, just amend the Notify plugin like this, or add the change directly to BackupMigrate::backup()?

danrod’s picture

danrod
Location Ottawa
commented

@DamienMcKenna amending the Notify plugin works for me, I applied the patch successfully on 5.1.x, not sure how to "force" the backup to fail in order to test this, any suggestions?

ivnish’s picture

ivnish
he/him
commented
Category: Task » Feature request

danrod opened merge request !71

danrod’s picture

danrod
Location Ottawa
commented

I made some changes in patch file to fix some PHPCS issues and I was able to test this, I'll set this to RTBC and leave it for others to test it as well.

danrod’s picture

danrod
Location Ottawa
commented
Status: Needs review » Reviewed & tested by the community
danrod’s picture

danrod
Location Ottawa
commented

Merged, thank you so much @DamienMcKenna

danrod’s picture

danrod
Location Ottawa
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • danrod committed c9a3f2d5 on 5.0.x 
    Issue #3357349: Improved logging when something fails