Problem/Motivation

When using the 3.x version, if you visit the Text formats and editors config page, there is a JS error that causes plugin settings not to appear on the page.

Steps to reproduce

Using this module, visit admin/config/content/formats and the ckeditor plugins settings does not appear and there is a JS error in the console:
Uncaught ReferenceError: baseStyle is not defined

Proposed resolution

Will provide patch to fix

CommentFileSizeAuthor
#5 issue-3356944-fix-ckeditor-plugin-settings-5.patch1.34 KBciprian.stavovei
#2 issue-3356944-fix-ckeditor-plugin-settings.patch1.2 KBebremner

Comments

ebremner created an issue. See original summary.

ebremner’s picture

ebremner commented
StatusFileSize
new issue-3356944-fix-ckeditor-plugin-settings.patch1.2 KB

Providing patch to fix.

gordon’s picture

gordon commented
Status: Active » Reviewed & tested by the community

I have tested this and it resolves this issue and stops it from crashing.

mikell’s picture

mikell commented

Can confirm this patch works

ciprian.stavovei’s picture

ciprian.stavovei commented
StatusFileSize
new issue-3356944-fix-ckeditor-plugin-settings-5.patch1.34 KB

Re-rolled the patch to work with latest version.

rajab natshah’s picture

rajab natshah
he/him
commented

Thanks, please, create an issue fork. and let us have an MR to merge

rajab natshah’s picture

rajab natshah
he/him
commented

Confirmed: baseStyle is defined only in js/anchor/plugin.js and used in js/link and js/unlink. Those are CKEditor 4 files, dead on Drupal 10 and up, so dropping them from 3.0.x resolves this. Thank you, ciprian.stavovei :)

rajab natshah’s picture

rajab natshah
he/him
commented
Status: Reviewed & tested by the community » Closed (won't fix)

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.