Problem/Motivation


FILE: /var/www/html/drupal_9.4/drupal/web/modules/contrib/reroute_email/tests/src/Functional/RerouteEmailBrowserTestBase.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------
 144 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
------------------------------------------------------------------------------------------------------------------------------------------

Time: 276ms; Memory: 12MB
CommentFileSizeAuthor
#2 coding-standard-3355949-2.patch887 bytesrohit rana

Issue fork reroute_email-3355949

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Rohit Rana created an issue. See original summary.

rohit rana’s picture

rohit rana commented
Assigned: rohit rana » Unassigned
Status: Active » Needs review
StatusFileSize
new coding-standard-3355949-2.patch887 bytes
rajneeshb’s picture

rajneeshb commented

Reviewed patch #2, patch applied cleanly and resolved the reported issue looks good to me. +1 for RTBC

ankitv18 made their first commit to this issue’s fork.

abyss’s picture

abyss commented
Version: 2.x-dev » 2.2.x-dev
Assigned: Unassigned » abyss
Status: Needs review » Active

We need to update and check on the 2.2.x branch

Abyss opened merge request !50

abyss’s picture

abyss commented
Assigned: abyss » Unassigned
Status: Active » Needs review

Move the changes to the 2.2.x branch.

bohart made their first commit to this issue’s fork.

  • bohart committed 9bf9f3a8 on 2.2.x authored by Abyss 
    Issue #3355949: Removed t() calls in classes (should be avoided).

  • bohart committed 7a4044ee on 2.1.x 
    Issue #3355949: Removed t() calls in classes (should be avoided).
bohart’s picture

bohart
Location Lutsk, Ukraine
commented
Status: Needs review » Fixed
Issue tags: +Coding standards

Committed to both 2.1.x (^D8.9 & <D9.3) and 2.2.x (^D9.4 & ^D10) branches.
This will be a part of the next releases of the modules soon.
Thanks @all!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.