Problem/Motivation

This is follow up of issue #2277795: Remove completely irrelevant addition of "menu-item__link" class in tabledrag.js

Steps to reproduce

Proposed resolution

Remove this unused CSS from core/themes/claro/css/components/tabledrag.pcss.css file.

.touchevents .draggable .menu-item__link {
  padding-top: var(--space-xs);
  padding-bottom: var(--space-xs);
}

Remaining tasks

User interface changes

NA

CommentFileSizeAuthor
#5 Screenshot 2023-04-24 at 1.06.18 PM.png104.46 KBsantosh_verma
#5 Screenshot 2023-04-24 at 1.06.03 PM.png44.25 KBsantosh_verma

Issue fork drupal-3355904

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Gauravvvv created an issue. See original summary.

gauravvvv’s picture

gauravvvv commented
Parent issue: » #2277795: Remove completely irrelevant addition of "menu-item__link" class in tabledrag.js

Gauravvvv opened merge request !3869

gauravvvv’s picture

gauravvvv commented
Status: Active » Needs review
santosh_verma’s picture

santosh_verma commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Screenshot 2023-04-24 at 1.06.03 PM.png44.25 KB
new Screenshot 2023-04-24 at 1.06.18 PM.png104.46 KB

Tested the comment #3

Unused css removed after the MR

santosh_verma’s picture

santosh_verma commented
bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Status: Reviewed & tested by the community » Postponed

Postponed on #2277795: Remove completely irrelevant addition of "menu-item__link" class in tabledrag.js, an issue I recommend closing instead of continuing work on, but I won't close it without at least some level of agreement from other contributors.

catch’s picture

catch
he/him
Primary language English
commented
Status: Postponed » Closed (duplicate)

Given that issue would require refactoring, we wouldn't just be removing the CSS, so I'm going to mark this one as duplicate.