Problem/Motivation

When using PHP 8.1, I am getting this error when on this page /admin/config/system/mailer/policy/add:
Warning: Undefined array key "sub_type" in Drupal\symfony_mailer\Form\PolicyAddForm->form() (line 49 of modules/contrib/symfony_mailer/src/Form/PolicyAddForm.php).

Steps to reproduce

Navigate to /admin/config/system/mailer/policy/add while using PHP 8.1

Proposed resolution

Replace:
if (!$definition['sub_type']) {
With:
if (!isset($definition['sub_type'])) {

CommentFileSizeAuthor
#7 symfony_mailer.undefined-subtype.3355536-7.patch840 bytesadamps
#4 interdiff.patch1.63 KBsakthi_dev
#4 sub-type-test-fails-4.patch1.94 KBsakthi_dev
#3 php8.1_undefined_key_sub_type-3355536.patch538 bytesjaydee1818
#2 php8.1_undefined_key_sub_type-3355536.patch537 bytesjaydee1818

Comments

jaydee1818 created an issue. See original summary.

jaydee1818’s picture

jaydee1818 commented
StatusFileSize
new php8.1_undefined_key_sub_type-3355536.patch537 bytes

Here's a patch that does the trick.

jaydee1818’s picture

jaydee1818 commented
StatusFileSize
new php8.1_undefined_key_sub_type-3355536.patch538 bytes

Take two - here's a patch that does the trick.

sakthi_dev’s picture

sakthi_dev commented
Status: Active » Needs review
StatusFileSize
new sub-type-test-fails-4.patch1.94 KB
new interdiff.patch1.63 KB

Created patch to resolve deprecated function. Please review.

The last submitted patch, 4: sub-type-test-fails-4.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

adamps’s picture

adamps commented
Title: PHP 8.1 error Undefined array key "sub_type" PolicyAddForm.php » Undefined array key "sub_type" in PolicyAddForm.php

Thanks for the report. I see it on PHP 8 so it's not only PHP 8.1.

adamps’s picture

adamps commented
StatusFileSize
new symfony_mailer.undefined-subtype.3355536-7.patch840 bytes
adamps’s picture

adamps commented

The bug is that the sub_type key is missing. I believe this is the right patch.

The tests are broken on PHP8.2 so that needs fixing separately.

  • AdamPS committed bd56521b on 1.x 
    Issue #3355536 by jaydee1818, sakthi_dev, AdamPS: Undefined array key "...
adamps’s picture

adamps commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.