Problem/Motivation

In #3123832: [META] Fix @todo items referencing closed issues we've discovered there's a @todo in \Drupal\Core\Database\StatementInterface::fetchObject.
This @todo is linked to an d.o. issue that is already closed: #3194677: Follow up for #3128548: Add parameters to StatementInterface::fetchObject.

This is the @todo:

   * phpcs:disable Drupal.Commenting
   * @todo Remove PHPCS overrides https://www.drupal.org/node/3194677.
   *
   * @param string|null $class_name
   *   Name of the created class.
   * @param array|null $constructor_arguments
   *   Elements of this array are passed to the constructor.
   * phpcs:enable

Steps to reproduce

Proposed resolution

#3194677: Follow up for #3128548: Add parameters to StatementInterface::fetchObject was closed as a duplicate of #3354672: [Meta] Adjust parameters in interfaces.

Let's replace the link in the @todo with the latter one.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3354951

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Spokje created an issue. See original summary.

spokje’s picture

Status: Active » Needs review
mondrake’s picture

Status: Needs review » Reviewed & tested by the community

yep, thanks

longwave’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed cb3fe405be to 10.1.x and 6323f56802 to 10.0.x and 44fae5c0fe to 9.5.x. Thanks!

  • longwave committed 6323f568 on 10.0.x
    Issue #3354951 by Spokje: Update @todo comment in \Drupal\Core\Database\...

  • longwave committed cb3fe405 on 10.1.x
    Issue #3354951 by Spokje: Update @todo comment in \Drupal\Core\Database\...

  • longwave committed 44fae5c0 on 9.5.x
    Issue #3354951 by Spokje: Update @todo comment in \Drupal\Core\Database\...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.