[8.x-1.x] Entity Clone template

Thank you for applying! Reviewers will review the project files, describing what needs to be changed.

Please read Review process for security advisory coverage: What to expect for more details and Security advisory coverage application checklist to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smoother review.

To reviewers: Please read How to review security advisory coverage applications, What to cover in an application review, and Drupal.org security advisory coverage application workflow.

While this application is open, only the user who opened the application can make commits to the project used for the application.

Reviewers only describe what needs to be changed; they don't provide patches to fix what reported in a review.

1. Fix PHPCS issues.

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml entity_clone_template/

FILE: entity_clone_template/entity_clone_template.info.yml
------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------
 11 | ERROR | [x] Expected 1 newline at end of file; 0 found
------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------


FILE: entity_clone_template/README.md
------------------------------------------------------------------------
FOUND 1 ERROR AND 7 WARNINGS AFFECTING 8 LINES
------------------------------------------------------------------------
  9 | WARNING | [ ] Line exceeds 80 characters; contains 114 characters
 13 | WARNING | [ ] Line exceeds 80 characters; contains 116 characters
 19 | WARNING | [ ] Line exceeds 80 characters; contains 108 characters
 20 | WARNING | [ ] Line exceeds 80 characters; contains 105 characters
 23 | WARNING | [ ] Line exceeds 80 characters; contains 119 characters
 24 | WARNING | [ ] Line exceeds 80 characters; contains 109 characters
 26 | WARNING | [ ] Line exceeds 80 characters; contains 120 characters
 27 | ERROR   | [x] Expected 1 newline at end of file; 3 found
------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------

2. FILE: entity_clone_template.services.yml

# File entity_clone_template.services.yml.

Remove comment.

3. FILE: src/EventSubscriber/EntityCloneTemplateSubscriber.php

  /**
   * Subscribed Events trigger.
   */
  public static function getSubscribedEvents() {

Use {@inheritdoc} comment.

Remember to change the status to Needs review when the project is ready for review.

@GuillaumeG,

I have reviewed the changes, and they look fine to me.

Let’s wait for other reviewers to take a look and if everything goes fine, you will get the role.

/**
 * Form submission handler called in hook_form_alter.
 *
 * @param array $form
 *   The form array.
 * @param \Drupal\Core\Form\FormStateInterface $form_state
 *   The form state value.
 */

Instead of which hook invokes the submission form handler, the short description should say to which form the submission handler is attached.

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the Slack #contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the reviewers.