The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.Problem/Motivation
Should be a quick issue to remove the icon. Will attempt to remove and not just hide. But if that doesn't work hide.
Steps to reproduce
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
| Comment | File | Size | Author |
|---|---|---|---|
| #22 | After.png | 27.52 KB | sharayurajput |
| #18 | After.png | 27.52 KB | sharayurajput |
| #18 | Before.png | 28.12 KB | sharayurajput |
| #13 | Screenshot 2023-04-12 at 11.23.09 AM.png | 207.34 KB | rohan-sinha |
| #7 | after_patch#5.png | 513.89 KB | sonam.chaturvedi |
Issue fork same_page_preview-3352976
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
cosmicdreams commentedComment #3
cosmicdreams commentedComment #5
ranjit1032002Created a patch for removing Pencil icon, please review.
Thank You.
Comment #6
cosmicdreams commentedThanks @Ranjit1032002 can you provide it as a Merge Request?
Comment #7
sonam.chaturvedi commentedVerified and tested patch #5 with 2.0.x-dev version on drupal 10.1.x-dev.
Patch applied cleanly
Test Results:
Pencil icon is removed. However, I think title "Preview" should be aligned left.
Refer attached before and after screenshot
Comment #8
cosmicdreams commentedCool. But can you provide this as an MR?
Comment #9
rohan-sinha commentedHi, @cosmicdreams, reviwed the patch #5, it works well but the patch fixes is inside core, so or for MR need to ovwerwite the same class in the module css.
Comment #11
ranjit1032002Hi, @cosmicdreams MR!35 created , please review.
Thank You.
Comment #12
rohan-sinha commentedThe MR looks good, fixed the issue, also the preview is aligned as expected by @sonam.chaturvedi on #7 , thnks
Comment #13
rohan-sinha commentedComment #14
cosmicdreams commentedBack to Needs Work with some review notes. I like the result, just have some comments about the implementation.
Comment #15
cosmicdreams commentedComment #16
ranjit1032002I have made changes in MR!35, Please review.
Comment #17
sharayurajput commentedWill review this issue
Comment #18
sharayurajput commentedMerge request !35 reviewed, its working good as per requirement added screenshot for the reference.
LGTM so moving status to RTBC
Comment #19
cosmicdreams commentedThe use of !important would have a severe impact to the rest of Drupal development as the styles introduced with this change would override other implementations in a way that would make it hard to undo. Please modify this change to exclude !important.
You can accomplish this be having greater selector specificity so that the scope of the change is assured to only impact our use case.
Comment #20
cosmicdreams commentedComment #21
ranjit1032002I have made changes in MR!35 by excluding !important, Please review.
Comment #22
sharayurajput commentedits also working instead of using !important so now we can move this issue to RTBC
Comment #23
sharayurajput commentedComment #25
rajeshreeputraRebased MR, changes looks good +1 RTBC.
Comment #26
cosmicdreams commentedFinally getting around to merging this.
Comment #29
brianperryThis fix looks to be in both 2.0 and 2.1 so marking as fixed.