Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#5 structure-sync-3351468-5-update.patch1.21 KBsimon georges
#3 structure_sync-module-changes.patch1.22 KBhimanshu_jhaloya

Issue fork structure_sync-3351468

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

himanshu_jhaloya created an issue. See original summary.

himanshu_jhaloya opened merge request !23

himanshu_jhaloya’s picture

himanshu_jhaloya commented
StatusFileSize
new structure_sync-module-changes.patch1.22 KB
leevh’s picture

leevh commented

I might be wrong, but this functionality seems crucial when the tid is what links terms to content. Otherwise the tid seems to keep changing when using structure sync. Thanks for this!

simon georges’s picture

simon georges commented
Version: 2.0.4 » 2.x-dev
Category: Task » Feature request
Status: Active » Needs review
StatusFileSize
new structure-sync-3351468-5-update.patch1.21 KB

This is an updated version of the patch for the latest version of the module.

mparker17 made their first commit to this issue’s fork.

mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented
Issue tags: +Needs tests, +Needs title update, +Needs issue summary update

To make this easier to review, I've rebased the merge request onto the latest 2.x.

A brief glance at the code in the merge request suggests that it has no tests. The Structure Sync maintainers prefer to accept merge requests that have passing automated tests. If you need help writing tests, please ask: I would be happy to help!

I've marked this issue as "Needs title update" and "Needs issue summary update" because it's unclear to me what feature you are trying to add to the module nor what feature is being fixed. I took a look at the code too, but the intent behind the change is still unclear to me.