CKEditor 5 ^36 compatibility — necessary for Drupal 10.1.x

I can confirm the same error after Drupal 9.5.6 upgrade. (TypeError.... formView is null)

Also tried 2.1.1+1-dev and no luck. Same error.

The update to CKEditor5 that caused the issue, introduced in 9.5.6 and 10.0.6, has been reverted in https://www.drupal.org/project/drupal/releases/9.5.7 and https://www.drupal.org/project/drupal/releases/10.0.7

This issue should remain open for compatibility with 10.1.x, which retains the CKEditor update.

Note the proximate trigger is const linkFormView = this.editor.plugins.get( 'LinkUI' ).formView; , https://git.drupalcode.org/project/editor_advanced_link/-/blob/2.x/js/ck... , which returns a null value.

Potential reference for refactoring: https://github.com/ckeditor/ckeditor5/issues/4836#issuecomment-1422740830

Confirmed Editor Advanced Link 2.1.1 is working with Drupal 9.5.7.

I spent hours on this over at #3317769.

See #3317769-33: Add support for linking to entities in CKEditor 5 and https://git.drupalcode.org/project/drupal/-/merge_requests/2909/diffs?co... for the exact root cause + solution. That solution also removes one hack:

+++ b/js/ckeditor5_plugins/editorAdvancedLink/src/editoradvancedlinkui.js
@@ -0,0 +1,93 @@
+    // This is a hack. Thic could be potentially improved by detecting when the
+    // form is added by checking the collection of the ContextualBalloon plugin.
+    editor.plugins.get( 'ContextualBalloon' )._rotatorView.content.on( 'add', ( evt, view ) => {

Facing the same issue with Drupal 10.1.0-alpha1

editor5.js?rtzgxi:472 TypeError: Cannot read properties of null (reading 'extendTemplate')
    at s._changeFormToVertical (editorAdvancedLink.js?v=10.1.0-alpha1:1:3968)
    at s.init (editorAdvancedLink.js?v=10.1.0-alpha1:1:3734)

Thanks for your time and hints and following up on this issue

Got this started but it needs work and I don't have a lot of experience with ckeditor 5.
It does not prevent wysiwyg from loading as it was happening before, but the extra fields are not being added. I get errors about a deprecation on the console linking to this https://ckeditor.com/docs/ckeditor5/latest/support/error-codes.html#erro...

We're facing the same issue with Drupal 10.1.0-beta1.
Having a look at the MR I have to admit I'm also very unsure how to solve this correctly for this case.

I have tried the code from MR on Drupal 10.1.0-beta1 and it indeed fixed fatal error. Unfortunately for extra fields only "Open in new window" is displayed and not others.

I think that the issue is now fixed in the MR. I moved everything inside the event listener for set:visibleView and it started working properly. Please review.

Also uploading patch of the current MR state

I tested the patch #16 and it works for the properties Title, CSS classes, Open in new window, and in combination with Linkit module.

In my case when I add the link button to CKEditor then the editor is not displayed.
After adding #16 everything seems to work as expected.

After applying patch #16 the ckeditor5 still won't load. The Console shows the following error message:

TypeError: this.editor.plugins.get(...).formView is null
    _changeFormToVertical http://localhost:8080/modules/contrib/editor_advanced_link/js/build/editorAdvancedLink.js?v=10.1.0-beta1:1
    init http://localhost:8080/modules/contrib/editor_advanced_link/js/build/editorAdvancedLink.js?v=10.1.0-beta1:1
ckeditor5.js:472:19
    attach http://localhost:8080/core/modules/ckeditor5/js/ckeditor5.js?rvm49a:472

Drupal 10.1.0-beta1
Advanced Link 2.1.1
PHP 8.1.6

The patch at #16 worked for me: D10.1-beta1; PHP 8.1.6; Adv link 2.1.1; Chrome 113.0.5672.126

Note: I cleared Drupal cache and the browser cache

Yes, clearing the browser cache made it work. Thanks @robcarr.
Now patch #16 works for me too.

adding as physical patch to keep our codebase as safe as possible. Thank you for the fix, fam!

How is patch from #23 different from patch in #16?

Pinged the maintainer. @Maintainer: Please note the RTBC was for Ptch #16

@a.dmitriiev or anyone else, would you like to update the MR with the patch contents from #16 to make it easier for the maintainer to merge?

Hi, impossible to apply the patch on drupal 10.1 would you have a solution? THANKS

  - Installing drupal/core (10.1.0): Extracting archive
  - Applying patches for drupal/core
    https://www.drupal.org/files/issues/2023-05-24/3350254-ckeditor-5-36-compatibility-16.patch (CKEditor 5 ^36 compatibility — necessary for Drupal 10.1.x)
   Could not apply patch! Skipping. The error was: Cannot apply patch https://www.drupal.org/files/issues/2023-05-24/3350254-ckeditor-5-36-compatibility-16.patch

Sorry, error on my part, because I applied the patch to the kernel. I have now correctly applied the patch to the module, but it does not work. I have errors in the console and ckeditor does not load.

        "patches": {
            "drupal/editor_advanced_link": {
                "CKEditor 5 ^36 compatibility — necessary for Drupal 10.1.x": "https://www.drupal.org/files/issues/2023-05-24/3350254-ckeditor-5-36-compatibility-16.patch"
            }
        },

Patch works, the mistake is on your side. You have to patch drupal/editor_advanced_link not core. Like in #28.

I have applied the patch to the module and cleaned the cacahe but I have this error in the console and ckeditor does not load:

TypeError: this.editor.plugins.get(...).formView is null
    _changeFormToVertical https://www.example.fr/modules/contrib/editor_advanced_link/js/build/editorAdvancedLink.js?v=10.1.0:1
    init https://www.example.fr/modules/contrib/editor_advanced_link/js/build/editorAdvancedLink.js?v=10.1.0:1
    promise callback*./packages/ckeditor5-core/src/index.ts/init/p/< https://www.example.fr/core/assets/vendor/ckeditor5/ckeditor5-dll/ckeditor5-dll.js?v=38.0.1:5
    p https://www.example.fr/core/assets/vendor/ckeditor5/ckeditor5-dll/ckeditor5-dll.js?v=38.0.1:5
    init https://www.example.fr/core/assets/vendor/ckeditor5/ckeditor5-dll/ckeditor5-dll.js?v=38.0.1:5
    initPlugins https://www.example.fr/core/assets/vendor/ckeditor5/ckeditor5-dll/ckeditor5-dll.js?v=38.0.1:5

Patch works for me. Thanks for this, thought I was in real trouble when I tested the Drupal update today.

@Anybody the patch in #16 was created from MR, so they should be in sync.

@zenimagine it might be also the cache in the browser. Try to clear browser cache.

patch #16 works for me on 10.1.0

Confirming patch #16 works on D10.1.0 with linkit module.

Thanks, it works. I had cleared cache in drupal but not in browser

Not compatible with 2.1.2

Thank you all!
I reworked the patch on top of the 2.x branch and fixed the last issue.

I've moved to "need to work" because MR and patches can't be applied.

Guys, I've created a new branch 3350254-ckeditor-5-36-2 and I've applied manually the patch #23. I'm uploading the new patch and I've updated the code.

(Update, I'll hide the patch because still not applicable )

jkamizato you can't apply the patch, because it is already merged to the module and the new version was released.

Moving to Closed Fixed as it's been already merged and available in the release

fyi, "Fixed" status gets moved to "Closed (fixed)" automatically after 14(?) days :)