Problem/Motivation

- Opening the Media Directory UI gives the following with PHP 8.2:
Deprecated function: Creation of dynamic property Drupal\entity_browser\Plugin\EntityBrowser\WidgetSelector\Single::$widget_ids is deprecated in Drupal\entity_browser\WidgetSelectorBase->__construct() (line 43 of modules/contrib/entity_browser/src/WidgetSelectorBase.php).

Steps to reproduce

- Attached MR will fix this

CommentFileSizeAuthor
#8 3350169-8.patch724 bytesjeroent

Issue fork entity_browser-3350169

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

j-vee created an issue. See original summary.

j-vee opened merge request !24

rajeshreeputra’s picture

rajeshreeputra
he/him
Location Pune
commented
Status: Needs review » Reviewed & tested by the community

Changes looks good to me.

ankitv18 made their first commit to this issue’s fork.

rajeshreeputra’s picture

rajeshreeputra
he/him
Location Pune
commented
Issue tags: +ACMS2023
ankitv18’s picture

ankitv18 commented
Assigned: j-vee » ankitv18
Status: Reviewed & tested by the community » Needs work
ankitv18’s picture

ankitv18 commented
Assigned: ankitv18 » Unassigned
jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
StatusFileSize
new 3350169-8.patch724 bytes

Created a patch to use in composer patches.

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Status: Needs work » Reviewed & tested by the community

The failing tests are not related to this issue. Currently this module doesn't support CKEditor5.

I reverted all the test changes and moved those changes to a dedicated issue: #3367194: [Entity Browser] Tests are failing on D10 .

Marking as RTBC, since the one-liner fixes the PHP8.2 error.

jurriaanroelofs’s picture

jurriaanroelofs commented

Would be great if this could be merged!

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

+1 for #10

Dave Reid made their first commit to this issue’s fork.

  • Dave Reid committed 0d8d25a1 on 8.x-2.x authored by j-vee 
    Issue #3350169 by Rajeshreeputra, ankitv18, JeroenT, j-vee: Fixed PHP 8....
dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Reviewed & tested by the community » Fixed

Merged the MR to 8.x-2.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.