Problem/Motivation

Warning: Undefined array key "params" in reroute_email_mail_alter()

Steps to reproduce

Install Drupal Symfony Mailer module.
Set Sendmail as mailer transport.

Proposed resolution

I submit a patch to fix this warning.

CommentFileSizeAuthor
reroute_email-params-undefined.patch506 bytesjmaerckaert

Issue fork reroute_email-3348106

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jmaerckaert created an issue. See original summary.

danrod’s picture

danrod
Location Ottawa
commented
Status: Active » Needs review
bohart’s picture

bohart
Location Lutsk, Ukraine
commented
Version: 2.2.0 » 2.2.x-dev
Status: Needs review » Needs work

This module was moved from deprecated DrupalCI to GitlabCI, the tests can't be run on .patch files anymore.
This way (uploading .patch files instead of Merge requests) is deprecated.
This will happen for all modules for the whole drupal-org in the near future.
Please be aware and do not upload .patch files. Merge requests should be created instead.
Thanks!

@see:
https://www.drupal.org/docs/develop/git/using-gitlab-to-contribute-to-dr...
https://www.drupal.org/docs/develop/git/using-gitlab-to-contribute-to-dr...

abyss’s picture

abyss commented
Assigned: Unassigned » abyss
Status: Needs work » Active

Abyss opened merge request !54

  • bohart committed c61b4e65 on 2.2.x authored by Abyss 
    Issue #3348106: Fixed Warning: Undefined array key "params" in...

  • bohart committed b8245f8d on 2.1.x 
    Issue #3348106: Fixed Warning: Undefined array key "params" in...
bohart’s picture

bohart
Location Lutsk, Ukraine
commented
Assigned: abyss » Unassigned
Status: Active » Fixed
Issue tags: +PHP warnings

Committed to both 2.1.x (^D8.9 & <D9.3) and 2.2.x (^D9.4 & ^D10) branches.
All of those versions require a minimum of PHP 7, so it's safe to have null coalescing operator here.

All tests are passed:
2.1.x - https://git.drupalcode.org/project/reroute_email/-/pipelines/24609
2.2.x - https://git.drupalcode.org/project/reroute_email/-/pipelines/24604

This will be a part of the next releases of the modules soon.
Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.