Problem/Motivation

When my client uploads particularly long file names, especially with version names at the end, they cannot tell which file is which because there is an ellipsis that truncates the file name.

Steps to reproduce

Add a file with a long name and view it in the browser.

Proposed resolution

I'm going to add a patch that shows the full file name on hover.

CommentFileSizeAuthor
#10 AfterMR.png21.24 KBanirudhsingh19
#10 BeforeMR.png14.65 KBanirudhsingh19
#3 file_browser__3347595_3__show_full_file_name_on_hover.patch405 bytesdzinkevich
#2 file_browser__3347595_1__show_full_file_name_on_hover.patch405 bytesdzinkevich

Issue fork file_browser-3347595

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

dzinkevich’s picture

dzinkevich commented

dzinkevich created an issue. See original summary.

Edit: missed a line in the patch

dzinkevich’s picture

dzinkevich commented
StatusFileSize
new file_browser__3347595_1__show_full_file_name_on_hover.patch405 bytes

Edit: missed a line in the patch, see #3

dzinkevich’s picture

dzinkevich commented
StatusFileSize
new file_browser__3347595_3__show_full_file_name_on_hover.patch405 bytes

Here is a patch that shows the full filename on hover:

d.fisher’s picture

d.fisher commented
Version: 8.x-1.4 » 2.x-dev
Assigned: Unassigned » d.fisher
Status: Active » Needs work

This looks and sounds sensible. This will need a MR through gitlab to ensure pipelines pass etc. I will do this!

d.fisher opened merge request !11

d.fisher’s picture

d.fisher commented
Status: Needs work » Needs review

Please test this still meets you requirements with MR!11 against the 2.x branch.
MR is here: https://git.drupalcode.org/project/file_browser/-/merge_requests/11

To apply via composer patches simply add .patch to the end of the url to reach a remote patch:
https://git.drupalcode.org/project/file_browser/-/merge_requests/11.patch

Let's get this one RTBC and merged!

d.fisher’s picture

d.fisher commented
Assigned: d.fisher » Unassigned
d.fisher’s picture

d.fisher commented

Anyone want to review this one and mark as RTBC if it solves the issue?

anirudhsingh19’s picture

anirudhsingh19 commented

reviewing this

anirudhsingh19’s picture

anirudhsingh19 commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new BeforeMR.png14.65 KB
new AfterMR.png21.24 KB

The MR solves the issue, now on hover the full name of the file can be seen. Attaching the screenshots for before and after on hover. I also tried to add a file with too long file name but the max-length is 240 characters, so the whole block overflowing out of the box won't be a problem here.

d.fisher’s picture

d.fisher commented
Status: Reviewed & tested by the community » Fixed

Merged to 2.x and will be in the next tagged release. Thank you! Marking as fixed.

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.