Compatibility for Drupal 10

the patch is not complete, see my description holistic.

My dev skills are not that strong, I could try it. I'm just not sure with the stuff about entity queries if I would get it changed properly.

The MR for compatibility already goes in the right direction, however, this is buggy, at the moment in no case use in productive environment. The patch itself applied clean and everything works as it should, existing subgroups can be edited/updated/displayed. BUT: as soon as a new subgroup is created an extremely ugly error occurs. Subgroups are created, but not linked to the group, here the logic is completely broken. Thus linked node types cannot be inserted into the subgroup or other entities.

On closer analysis I found that after the patch no relationships are created for subgroup_depth, subgroup_left, subgroup_right, subgroup_tree. The logic for this seems to be completely missing. On further analysis and testing, I also get error messages when new entities are added to the subgroup.

My setup consists of Drupal 9.5.9, PHP 8.1, Group 1.5 and Subgroup 1.0.2

The website encountered an unexpected error. Please try again later.
Error: Undefined constant "Drupal\subgroup\Event\Symfony\Contracts\EventDispatcher\Event" in include() (line 6 of modules/contrib/subgroup/src/Event/GroupLeafEvent.php).
include() (Line: 582)
Composer\Autoload\{closure}('/var/www/html/docroot/modules/contrib/subgroup/src/Event/GroupLeafEvent.php') (Line: 433)
Composer\Autoload\ClassLoader->loadClass('Drupal\subgroup\Event\GroupLeafEvent') (Line: 91)
subgroup_group_update(Object)
call_user_func_array(Object, Array) (Line: 426)
Drupal\Core\Extension\ModuleHandler->Drupal\Core\Extension\{closure}(Object, 'subgroup') (Line: 405)
Drupal\Core\Extension\ModuleHandler->invokeAllWith('group_update', Object) (Line: 433)
Drupal\Core\Extension\ModuleHandler->invokeAll('group_update', Array) (Line: 249)
Drupal\Core\Entity\EntityStorageBase->invokeHook('update', Object) (Line: 900)
Drupal\Core\Entity\ContentEntityStorageBase->invokeHook('update', Object) (Line: 598)
Drupal\Core\Entity\EntityStorageBase->doPostSave(Object, 1) (Line: 781)
Drupal\Core\Entity\ContentEntityStorageBase->doPostSave(Object, 1) (Line: 523)
Drupal\Core\Entity\EntityStorageBase->save(Object) (Line: 804)
Drupal\Core\Entity\Sql\SqlContentEntityStorage->save(Object) (Line: 339)
Drupal\Core\Entity\EntityBase->save() (Line: 51)
Drupal\subgroup\Entity\GroupSubgroupHandler->writeLeafData(Object, 1, 2, 3, 8610) (Line: 278)
Drupal\subgroup\Entity\SubgroupHandlerBase->doAddLeaf(Object, Object) (Line: 103)
Drupal\subgroup\Entity\GroupSubgroupHandler->doAddLeaf(Object, Object) (Line: 213)
Drupal\subgroup\Entity\SubgroupHandlerBase->addLeaf(Object, Object) (Line: 240)
subgroup_group_content_insert(Object)
call_user_func_array(Object, Array) (Line: 426)
Drupal\Core\Extension\ModuleHandler->Drupal\Core\Extension\{closure}(Object, 'subgroup') (Line: 405)
Drupal\Core\Extension\ModuleHandler->invokeAllWith('group_content_insert', Object) (Line: 433)
Drupal\Core\Extension\ModuleHandler->invokeAll('group_content_insert', Array) (Line: 249)
Drupal\Core\Entity\EntityStorageBase->invokeHook('insert', Object) (Line: 900)
Drupal\Core\Entity\ContentEntityStorageBase->invokeHook('insert', Object) (Line: 598)
Drupal\Core\Entity\EntityStorageBase->doPostSave(Object, ) (Line: 781)
Drupal\Core\Entity\ContentEntityStorageBase->doPostSave(Object, ) (Line: 523)
Drupal\Core\Entity\EntityStorageBase->save(Object) (Line: 804)
Drupal\Core\Entity\Sql\SqlContentEntityStorage->save(Object) (Line: 157)
Drupal\group\Entity\Group->addContent(Object, 'subgroup:MYSUBGROUPNAME', Array) (Line: 656)
group_content_entity_submit(Array, Object)
call_user_func_array('group_content_entity_submit', Array) (Line: 114)
Drupal\Core\Form\FormSubmitter->executeSubmitHandlers(Array, Object) (Line: 52)
Drupal\Core\Form\FormSubmitter->doSubmitForm(Array, Object) (Line: 597)
Drupal\Core\Form\FormBuilder->processForm('group_MYSUBGROUPNAME_add_form', Array, Object) (Line: 325)
Drupal\Core\Form\FormBuilder->buildForm(Object, Object) (Line: 48)
Drupal\Core\Entity\EntityFormBuilder->getForm(Object, 'add', Array) (Line: 368)
Drupal\group\Entity\Controller\GroupContentController->createForm(Object, 'subgroup:MYSUBGROUPNAME')
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 580)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 169)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 81)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 58)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 49)
Drupal\remove_http_headers\StackMiddleware\RemoveHttpHeadersMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 718)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

Have now created the first patch that works for me. No errors are thrown, subgroups can be edited and created. Fixed minor coding standards, set minimum group version to 1.5, declared Drupal 9.5 as minimum version. Tested under PHP 8.1, Drupal 9.5.9 & Drupal 10.x

Feedback and testing would be appreciated.

Unfortunately, the patch with the adjustments for coding standards collides with the important patch #3281672

The patch of @Jan-E I see as mandatory for the next release of Subgroup. So here is the minimum version for compatibility for Drupal 10.

Patch rerolled, on closer testing it was noticed that in the subgroup.module the statement for $event_dispatcher was in the wrong order and led to a fatal error under Drupal 10 when creating or updating a subgroup.

Also here, found some more. Existing accessCheck should NOT be changed, patch reroled.