Problem/Motivation

Users who have permission to "Manipulate all queues" and "Manipulate queues", can't click on the admin menu item :

Structure > Entityqueues > Custom Entityqueue Name

They receive a access denied.

entity queue menu items

If a user clicks on any of these, with the permissions shown above, they get access denied. I think they should be taken to the EDIT ITEMS interface instead.

When they click on STRUCTURE > ENTITYQUEUES they can see the list of queues, and click on edit items there.

Steps to reproduce

1. Give users "Manipulate all queues" and "Manipulate queues" permissions.
2. Ask them to use the admin toolbar to access a specific queue as shown in the screen shot above.

Proposed resolution

Make those menu items take you to the EDIT ITEMS screen instead.

This should be the default, for many reasons, but mainly that most interactions with this UX will be in managing the items, not configuring them.

CommentFileSizeAuthor
#8 3347301_8.patch4.13 KBkobusvw
#7 entityqueue-wonky-permissions-for-editing-items-in-queue-3347301-7.patch4.61 KBdabbor
#2 3347301.patch4.35 KBamateescu
screenshot_2023-03-10_at_13_46_48.png49.15 KBalphex

Issue fork entityqueue-3347301

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

alphex created an issue. See original summary.

amateescu’s picture

amateescu commented
Status: Active » Needs review
StatusFileSize
new 3347301.patch4.35 KB

Make those menu items take you to the EDIT ITEMS screen instead.

This is a good point, it's also what we do on the queue list page where we link to either the edit items page for simple queues and to the subqueue list page for multiple subqueues.

I got this far with a patch but the admin menu still uses the queue's edit link for that menu item.. couldn't yet figure out why.

dieterholvoet made their first commit to this issue’s fork.

dieterholvoet opened merge request !36

dieterholvoet’s picture

dieterholvoet commented

I created a MR with a rebased version of 3347301.patch.

dieterholvoet’s picture

dieterholvoet commented
dabbor’s picture

dabbor commented
StatusFileSize
new entityqueue-wonky-permissions-for-editing-items-in-queue-3347301-7.patch4.61 KB

Adding a patch file for safe referencing in composer based on the MR with rebased version provided above (https://git.drupalcode.org/project/entityqueue/-/merge_requests/36.patch) to be able to be able to use it with the latest release 8.x-1.9 ( https://www.drupal.org/project/entityqueue/releases/8.x-1.9 ).

kobusvw’s picture

kobusvw commented
StatusFileSize
new 3347301_8.patch4.13 KB

Update of Patch to work with 8.x.1.9

cb’s picture

cb
Location Sydney
commented

I have been reading over the changes in 1.10 and it appears that https://www.drupal.org/project/entityqueue/issues/3396136 resolves this issue. @amateescu has commented and committed the issue there.

@kobusvw @dieterholvoet @dabbor What do you think?

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Related issues: +#3581435: After saving an entityqueue 403 with update permissions

If this is indeed fixed and a duplicate, here's something similar in the latest stable release that should be fixed then: #3581435: After saving an entityqueue 403 with update permissions

amateescu’s picture

amateescu commented
Version: 8.x-1.6 » 8.x-1.x-dev
Status: Needs review » Fixed

Pushed a change so we don't regress on the fixes from #3396136: Fixes to permissions and merged, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.