Problem/Motivation

If I create a views filter group with OR, the system displays AND, as in the enclosed screenshot.

Steps to reproduce

Create an OR filter group in any view and observe that it says AND, not OR, as in the enclosed screenshot.

Proposed resolution

Display OR, not AND, in bold and italic, next to each filter within an OR group.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#14 Screenshot 2024-12-04 at 15-01-05 Test view (Content) Drush Site-Install.png52.58 KBmortona2k
#14 Screenshot 2024-12-04 at 15-04-56 Test view (Content) Drush Site-Install.png51.81 KBmortona2k
#10 interdiff-8_10.txt678 bytesgauravvvv
#10 3346391-10.patch2.28 KBgauravvvv
#9 3346391-nr-bot.txt1.13 KBneeds-review-queue-bot
#8 3346391-7.patch2.28 KBtanuj.
#6 interdiff_3-6.txt707 bytestanuj.
#6 3346391-6.patch2.29 KBtanuj.
#5 3346391-nr-bot.txt1.33 KBneeds-review-queue-bot
#4 Group_filter_2.png54.22 KBsakthi_dev
#4 Group_filter_1.png54.5 KBsakthi_dev
#3 views-group-filter-label-issue-3346391-3.patch2.28 KBsakthi_dev
Screenshot 2023-03-06 at 8.25.08 PM.jpg285.75 KBalberto56

Issue fork drupal-3346391

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

alberto56 created an issue. See original summary.

sakthi_dev’s picture

sakthi_dev commented
Assigned: Unassigned » sakthi_dev
sakthi_dev’s picture

sakthi_dev commented
Assigned: sakthi_dev » Unassigned
Status: Active » Needs review
StatusFileSize
new views-group-filter-label-issue-3346391-3.patch2.28 KB

Created a patch for filter group Operator label. Please review.

sakthi_dev’s picture

sakthi_dev commented
StatusFileSize
new Group_filter_1.png54.5 KB
new Group_filter_2.png54.22 KB

Attached the working Screenshots of the patch in #3

needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Needs review » Needs work
StatusFileSize
new 3346391-nr-bot.txt1.33 KB

The Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

tanuj.’s picture

tanuj. commented
Status: Needs work » Needs review
StatusFileSize
new 3346391-6.patch2.29 KB
new interdiff_3-6.txt707 bytes

Tried to fix CCF on #3.

Status: Needs review » Needs work

The last submitted patch, 6: 3346391-6.patch, failed testing. View results

tanuj.’s picture

tanuj. commented
Status: Needs work » Needs review
StatusFileSize
new 3346391-7.patch2.28 KB

i changed val() function to value() reverting it.

needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Needs review » Needs work
StatusFileSize
new 3346391-nr-bot.txt1.13 KB

The Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

gauravvvv’s picture

gauravvvv commented
Status: Needs work » Needs review
StatusFileSize
new 3346391-10.patch2.28 KB
new interdiff-8_10.txt678 bytes

Used element.value instead of $(element).val() in patch #8. Attached interdiff for same. please review

Status: Needs review » Needs work

The last submitted patch, 10: 3346391-10.patch, failed testing. View results

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

mortona2k made their first commit to this issue’s fork.

mortona2k’s picture

mortona2k commented
StatusFileSize
new Screenshot 2024-12-04 at 15-04-56 Test view (Content) Drush Site-Install.png51.81 KB
new Screenshot 2024-12-04 at 15-01-05 Test view (Content) Drush Site-Install.png52.58 KB

I applied the patch to an issue fork for testing, but it is not working for me.

I was able to get it to display the opposite value for both Or and And, unlike what is specified in the title.

It seems like the filter for the operator selection is changing every group label and not just it's own.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.