Elasticsearch Connector module needs to be updated to use short array syntax as per new coding standard and other general issues with coding standards.

CommentFileSizeAuthor
#4 Patch error 3346008.png218.7 KBriddhi.addweb
#2 elasticsearch_connector-coding-standard-updates-3346008-2.patch79.51 KBgoyalsushant

Issue fork elasticsearch_connector-3346008

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

goyalsushant created an issue. See original summary.

goyalsushant’s picture

goyalsushant commented
StatusFileSize
new elasticsearch_connector-coding-standard-updates-3346008-2.patch79.51 KB

Please find the attached patch for the issue and review the same.

goyalsushant’s picture

goyalsushant commented
Assigned: goyalsushant » Unassigned
Status: Active » Needs review
riddhi.addweb’s picture

riddhi.addweb commented
Status: Needs review » Needs work
StatusFileSize
new Patch error 3346008.png218.7 KB

I am facing an error while applying "elasticsearch_connector-coding-standard-updates-3346008-2" patch.
Please check the screenshot for the same.

mparker17 made their first commit to this issue’s fork.

mparker17 opened merge request !107

mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented
Version: 8.x-7.0-alpha4 » 8.x-7.x-dev
Category: Bug report » Feature request
Priority: Normal » Minor
Status: Needs work » Reviewed & tested by the community
Issue tags: -Coding standards

Fantastic. Testbot likes it. Moving to RTBC. I wrote the patches from scratch so I'm not crediting previous commenters.

  • mparker17 committed 256dd409 on 8.x-7.x 
    [#3346008] feat: Coding Standards Updates

By: mparker17
mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented
Status: Reviewed & tested by the community » Fixed
Issue tags: +Needs issue summary update

Merged.

I should update the issue summary for documentation purposes.

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented
Status: Fixed » Closed (fixed)

Closing early, since this type of issue is ripe for commit/credit farming.