Possibly stupid question: will this project become D10 compatible?

CommentFileSizeAuthor
#17 3343994--upgrade_drupal_10.patch4 KBdom.
#10 drupal-10-compatibility-3343994-10.patch679 bytesastringer
#9 masonry_d10.patch981 bytesastringer
#8 D10-fixes-3343994.patch309 bytesluismagr
#7 D10-fixes-3343994.patch1.87 KBluismagr
#3 upgrade status report.png110.27 KBannmarysruthy

Issue fork masonry-3343994

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

zJoriz created an issue. See original summary.

annmarysruthy made their first commit to this issue’s fork.

annmarysruthy’s picture

annmarysruthy commented
Assigned: Unassigned » annmarysruthy
StatusFileSize
new upgrade status report.png110.27 KB

The module was scanned using upgrade status for checking Drupal 10 compatibility. 2 Issues were found in the module

annmarysruthy opened merge request !2

annmarysruthy’s picture

annmarysruthy commented
Assigned: annmarysruthy » Unassigned
Status: Active » Needs review

Raised MR!2 for fixing the compatibility issues mentioned in #3. Please Review.

luismagr made their first commit to this issue’s fork.

luismagr’s picture

luismagr commented
StatusFileSize
new D10-fixes-3343994.patch1.87 KB

Hi,

This patch doesn't apply to me and contains more changes than what upgrade_status indicates. This is one patch for the module with the problems reported by upgrade_status.

Hope that it helps

luismagr’s picture

luismagr commented
StatusFileSize
new D10-fixes-3343994.patch309 bytes

Hi,

Attached a new patch as the previous didn't apply.

astringer’s picture

astringer commented
StatusFileSize
new masonry_d10.patch981 bytes

None of these worked for me.

#5 has 2 extra commits in it, and absolutely would not apply.

I'm not sure what's going on in #6, but per the author it does not apply.

#7 applies, but only removed "core: 8.x" from the masonry.info.yml and we need to do more than that for D10.

I have a patch that works, but I have a nested doc root and so does this patch -- apparently I don't know how to make a patch that works for everyone. (Happy to figure it out. Just not happening today.)

I've attached my file so you can see what I did, it' really simply. In case anyone gets back here and needs it before I get back here. Drupal 9 EOL is coming up, these are simple changes, would be great if we could get in a new version. ASAP.

Sorry I couldn't do more today.

astringer’s picture

astringer commented
StatusFileSize
new drupal-10-compatibility-3343994-10.patch679 bytes

Here is a replacement that follows the Drupal instructions for standardizing patches.

It only makes the 2 changes required by Upgrade Status.

Please review.

astringer’s picture

astringer commented

FYI, the above patch in #10 applies only to 8.x-1.x-dev, not to 8.x-1.2.

astringer’s picture

astringer commented
Version: 8.x-1.2 » 8.x-1.x-dev

Change version to 8.x-1.x-dev because that is what the patches apply to.

astringer’s picture

astringer commented

Okay the original Merge request in #5 actually works. All the code in it appears to be required for Drupal 10.

It applies, but ONLY to the dev version (8.x-1.x-dev).

It works for me on 10.0.5, on 2 different sites.

You will likely also need the patch, below, if you switch to the dev version from the recommended version. https://www.drupal.org/project/masonry/issues/3231169

I am going to change this to RTBC. And hide both of my temp patches. And the patches in #7 and 8 to avoid any future confusion.

Would be nice if someone else could verify and contact the maintainer.

astringer’s picture

astringer commented
Status: Needs review » Reviewed & tested by the community
bogdog400’s picture

bogdog400 commented

Yes. I'll test this week. But it would be good if the maintainer might move this into the dev branch for wider testing.

hockey2112’s picture

hockey2112 commented

Any word on a release date for the D10 version?

dom.’s picture

dom. commented
StatusFileSize
new 3343994--upgrade_drupal_10.patch4 KB

Here is the patch I am committing after all.

  • Dom. committed 33989db2 on 2.x 
    Issue #3343994 by luismagr, annmarysruthy, astringer, Dom.: Drupal 10...
dom.’s picture

dom. commented
Status: Reviewed & tested by the community » Fixed
hockey2112’s picture

hockey2112 commented

Is it committed/released? I do not see the D10 version on the front page yet. Thanks!

bogdog400’s picture

bogdog400 commented

Me neither.

dom.’s picture

dom. commented
Status: Fixed » Closed (fixed)

Release 2.0.0 published.

hockey2112’s picture

hockey2112 commented

Thank you! Will Masonry Views for D10 be published today as well? (https://www.drupal.org/project/masonry_views/issues/3288460)

dom.’s picture

dom. commented

I won't have time today. But it is already pushed in the 2.x branch if needed so that should be soon.

albeorte closed merge request !2