Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.This was pointed out in #3097459: Docs and Code improvements, dead code removal, some fixes.
I would appreciate a review of the entire code base to see if this is the only place that needs to be changed.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | with patch-1.png | 336.7 KB | paraderojether |
| #5 | with patch.png | 251.69 KB | paraderojether |
| #2 | 3342920-2-ternary-short-form.patch | 2.32 KB | tr |
Comments
Comment #2
tr commentedComment #4
tr commentedComment #5
paraderojether commentedHi @TR
I applied patch #2, and it works fine for me. Please look at the screenshot attached.
Thank You.
Comment #6
tr commented@paraderojether The purpose of posting a patch, like I did in in #2, is to allow DrupalCI (the "testbot") to test the patch. The testbot applies the patch and runs the automated tests, and the results may be seen by clicking on the green box in #2 labeled "PHP 8.1 & MySQL 5.7, D10.1 24 pass". The green color shows that the patch applied cleanly and passed all the tests.
Because of this, there is absolutely no need to report that the patch can be applied - we already know that. There is no need for screen shots - the test output already shows the patch can be applied. There is also no benefit to that sort of review, because it doesn't tell us anything we don't already know.
In an issue like this, what is needed is some information that the testbot doesn't provide. For instance, did you try to change the module settings from the modified form after the patch was applied? Were your settings changes saved? Did you review the rest of the code base like I asked to see if there were any other places that need a similar change? I personally found one other place, but I haven't posted a new patch yet. It would help if someone else looked at this to see if there is something I missed.
Comment #8
tr commentedCommitted.