Problem/Motivation

In some cases, the external icon is redundant and used solely as a visual progressive enhancement, so we could hide decorative icons from screen readers.
This could be achieved with the property aria-hidden="true" that right now is not available on the module.

Proposed resolution

An extra configuration called "Hide decorative icons from screen readers" add the aria-hidden
tag and according to your site you can set it as true/false

User interface changes

No changes here

API changes

Add the extra configuration "Hide decorative icons from screen readers (extlink_hide_icons)"

CommentFileSizeAuthor
#5 extlink-option.png5.75 KBtyler36
#5 extlink-disabled.png12.79 KBtyler36
#5 extlink-enabled.png12.96 KBtyler36
#2 extlink-icons_screen_readers-3342433-2.patch7.4 KBfabiansierra5191

Issue fork extlink-3342433

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

fabiansierra5191 created an issue. See original summary.

fabiansierra5191’s picture

fabiansierra5191 commented
Status: Active » Needs review
StatusFileSize
new extlink-icons_screen_readers-3342433-2.patch7.4 KB

fabiansierra5191 opened merge request !7

jidrone’s picture

jidrone commented

It is working fine and it makes sense based on the explanation found at https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attribut...

tyler36’s picture

tyler36 commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new extlink-enabled.png12.96 KB
new extlink-disabled.png12.79 KB
new extlink-option.png5.75 KB

Works well on Drupal `10.0.3`

## Test

1. Enable module
2. Add external Link field to Article node.
3. Create new article with external link.
4. Confirm code has aria-hidden="false" in DEV-TOOLS

5. Visit `/admin/config/user-interface/extlink` and enable setting.

6. Flush cache.
7. Visit article and confirm code has aria-hidden="true" in DEV-TOOLS

chris matthews’s picture

chris matthews commented
Version: 8.x-1.7 » 8.x-1.x-dev
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Reviewed & tested by the community » Needs work

Thanks, conflicts need to be resolved now.

Chandreshgiri Gauswami made their first commit to this issue’s fork.

chandreshgiri gauswami’s picture

chandreshgiri gauswami commented
Status: Needs work » Needs review

Resolved conflicts.

bernardm28’s picture

bernardm28 commented
Status: Needs review » Reviewed & tested by the community

It works as expected. Thanks for the MR.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Reviewed & tested by the community » Fixed

Thanks, merged into dev!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.