Use Drupal.dialog call instead of jQuery dialog

Tested and this is now working well.

Have tested the patch and it appears to solve one of the issues that I raised on https://www.drupal.org/project/autologout/issues/3361785, so I'm happy that the code does what it's supposed to.

Prior to installing this patch, not only was it using jQuery, but it seemed to be inconsistent with the regularity of displaying the modal. Now it's showing every time.

Going to need to sort out the failing tests though.

Added the patch to issue fork for easier maintaining. The tests are failing because of the core migration issue #3192893: [META] Serialization issues in Migration tests, but the code provided does seem to work, but setting the status to needs review, so somebody else can also again re-test and confirm it's working as expected.

Rebased the MR, tests are passing, testing by hand the modal also works fine.

While the patch is the same as the issue fork, I'll hide the file since DrupalCI tests are deprecated, and without the tests fix they will never pass, if you need a patch you can use plain diff or generate a patch file using GitLab.

Setting the issue to RTBC.

Changed as much of JQuery to plain JS as I could, also removed the duplicated dialogs appearing when clicking on "Yes" button. There could be an issue of logging out after 10s after first "Yes" in D10, which is covered in #3390135: Drupal 10 second dialog logout. Needs manual testing to confirm everything is working as expected, the automated test are passing.

Local and gitlabCI tests are passing, testing by hand also works correctly. Just in case locally merged #3390135: Drupal 10 second dialog logout and that fixed the second dialog instantly closing. With this fix, there is no need for #3390069: Multiple dialogs open. I think this can be merged.

The fork appears to have merge conflicts, please fix and I will merge them in.

Fixed merge conflicts. Back to you @jrglasgow.

Fixed for 2.0.x-dev

Setting to RTBC for 1.x

*EDIT*
oops
*END EDIT*

setting back

I am testing this patch with version 2.0.0 and it appears that these changes:

$(event.target).trigger('preventAutologout'); => document.dispatchEvent(new Event('preventAutologout'));
$('body').bind('preventAutologout', function (event) { => document.body.addEventListener('preventAutologout', function (event) {

are not properly triggering the 'preventAutologout' event. I'm being logged out despite 'mousemove' & 'keyup' events triggering, and I'm not seeing the preventAutologout event happening at all.

Update: doing more testing, and I believe the issue can be resolved with this change, adding ".body" into the dispatchEvent() lines.

document.body.dispatchEvent(new Event('preventAutologout'));

The issue appears to be that some of the JS is using document.xyz and others using document.body.xyz.

based on latest report

I've updated the branch to fix the JS scope and event issues I found.

Hi all,

The MR resolved most of the issues I was also encountering, but the attachBehaviors was firing multiple times. This caused init() to be invoked multiple times stacked. While clicking "Yes" would dismiss the dialog, the subsequent init() calls would still invoke logout shortly thereafter.

The code tries to prevent this by checking if the context is "document", but there can still be multiple attach calls with document as the context.

I've added a commit that uses drupal once, so that the behavior is only attached once, which seems to resolve this issue.

I also add the new classes property, so this works with D10.3.

Lastly, I created a new fork that targets the 2.x branch, given that is the latest version.

The events are getting triggered with the document.body.change. The addition of once does not completely resolve the issue of logging our after clicking yes in the dialog. It does resolve it on a first yes click, but after the third or forth time, the automatic logout still happens.
The logging out even when clicking yes, does seem to be resolved in #3390135: Drupal 10 second dialog logout, so marking this issue as RTBC, so it can get first merged so the other issue can get tested and possibly merged and then any additional corrections can be applied to it.

Added some queries to the MR

I think this is an important ticket to get merged next. Hopefully the queries can be looked at, and this can be prioritised>
With this in some of the other tickets may be resolved already, and so the march towards #3390554: [META] Roadmap to new release can progress.

I was having issues with the dialogue opening and closing, and also with the Yes button extending the time.

I have built on #76, but altered a couple of things to address the concerns mentioned above.

Please review the new MR.

Just tested MR90 and can confirm that the multiple modal issue referenced in https://www.drupal.org/project/autologout/issues/3469258 is resolved by this MR. As mentioned in comment #31, the issue of logging out when clicking "Yes" is resolved for the first couple of clicks, but auto logout happens on the 3rd or 4th click. But (again), as mentioned, the follow on changes in https://www.drupal.org/project/autologout/issues/3390135 fix the issue.

I've attached a patch for anyone else who wants to test the MR.

I agree with others here though that this is a high priority ticket to get merged in so we can move forward with incorporating fixes from other tickets for a new release.

I did push up a commit fixing the bulk of the eslint errors. I don't think it makes sense to try and resolve the outstanding phpstan errors on the MR since the associated files look like they're only relevant to d6 and d7, so it might be better served to have a separate issue ticket resolving the deprecation errors.

Replacing my previous patch with one that is correctly exported '^^

Will mark this RTBC based on the last comment. It's hard to check changes in code, when there are multiple branches that basically do the same. The changes then get lost and it takes too much effort to actually find the changes made.

The only issue I have is with the failing tests for composer (next major). Probably the gitlab-ci file is not updated for the newer version, but that can be a separate issue if needed (did not check if already exists/is solved).

Amazing, thank you. As soon as I get a moment, I'll get this merged and the others mentioned in: #3390554: [META] Roadmap to new release

The issue with the composer failing seems to be because of js_cookie dependency. And I think there is an issue that already removes that.

I have merged #3557620: Remove JS Cookie dependency to 2.x and then added that to this branch to tidy up the failing tests.

Merged