Multiple dialogs open [#3390069]

Problem/Motivation

When the timer runs out and the dialog opens up after the first time this happens, there will be multiple dialogs open.

Steps to reproduce

Install and configure the module (lower the timeout time, to make it easy to test)
Go to main page and wait
The first time the dialog opens click the button to stay logged in
When the dialog opens for the second or the nth time, there will be multiple dialogs. Spamming the stay logged in button will still correctly reset the timer

Proposed resolution

Check if there is an open dialog in the background and close it before creating a new one. Honestly, this whole JS file will need to be refactored sometime in the future, over the years fixes were added and much of the code is outdated with modern JS.

Issue fork autologout-3390069

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

1 hidden branch

3390069-multiple-dialogs-open

changes, plain diff MR !43

Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

27 September 2023 at 09:01

admirlju created an issue. See original summary.

Comment #2

27 September 2023 at 10:49

admirlju opened merge request !43

Comment #3

admirlju commented 27 September 2023 at 10:49

Status:

Active

» Needs work

Comment #4

admirlju commented 27 September 2023 at 10:51

Issue summary:

View changes

Comment #5

admirlju commented 27 September 2023 at 11:04

Status:

Needs work

» Needs review

So it looks like the proposed solution does fix the problem. But as I said, this whole JS file is a mess and should be refactored in the future. Issue ready for review.

Comment #6

deaom commented 28 September 2023 at 12:39

Status:

Needs review

» Postponed

This needs to be re-visited once #3339695: Use Drupal.dialog call instead of jQuery dialog is committed, as there were some changed added that should solve the issue already, so for now postponing it.