Fix the issues reported by phpcs [#3339557]

GitLab CI reports PHP_CodeSniffer warnings/errors which should be fixed.

FILE: ...odules/custom/jsonrpc-3436320/tests/src/Functional/ResponseHeadersTest.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 16 | ERROR | Missing member variable doc comment
    |       | (Drupal.Commenting.VariableComment.Missing)
--------------------------------------------------------------------------------
FILE: ...eb/modules/custom/jsonrpc-3436320/tests/src/Functional/JsonRpcTestBase.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 15 | WARNING | The class short comment should describe what the class does and
    |         | not simply repeat the class name
    |         | (Drupal.Commenting.ClassComment.Short)
--------------------------------------------------------------------------------
FILE: ...s/issue/jsonrpc-3436320/web/modules/custom/jsonrpc-3436320/src/Handler.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------------
 155 | WARNING | [x] '@TODO: Remove the following when PHP7 is the minimum
     |         |     supported version.' should match the format '@todo Fix
     |         |     problem X here.'
     |         |     (Drupal.Commenting.TodoComment.TodoFormat)
 218 | WARNING | [x] 'TODO: Add cacheability metadata here.' should match the
     |         |     format '@todo Fix problem X here.'
     |         |     (Drupal.Commenting.TodoComment.TodoFormat)
 219 | WARNING | [x] Inline @var declarations should use the /** */ delimiters
     |         |     (Drupal.Commenting.InlineVariableComment.VarInline)
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...436320/web/modules/custom/jsonrpc-3436320/src/Shaper/RpcRequestFactory.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
--------------------------------------------------------------------------------
  12 | ERROR   | [x] Use statements should be sorted alphabetically. The first
     |         |     wrong one is Drupal\jsonrpc\ParameterDefinitionInterface.
     |         |     (SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.IncorrectlyOrderedUses)
 106 | ERROR   | [x] Use null coalesce operator instead of ternary operator.
     |         |     (SlevomatCodingStandard.ControlStructures.RequireNullCoalesceOperator.NullCoalesceOperatorNotUsed)
 177 | WARNING | [x] 'TODO: Wrap other shaper transformations in a similar way
     |         |     for nicer' should match the format '@todo Fix problem X
     |         |     here.' (Drupal.Commenting.TodoComment.TodoFormat)
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...320/web/modules/custom/jsonrpc-3436320/src/Plugin/JsonRpcMethodManager.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------------
  7 | ERROR   | [x] Use statements should be sorted alphabetically. The first
    |         |     wrong one is Drupal\Core\Cache\CacheBackendInterface.
    |         |     (SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.IncorrectlyOrderedUses)
 41 | WARNING | [x] Inline @var declarations should use the /** */ delimiters
    |         |     (Drupal.Commenting.InlineVariableComment.VarInline)
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...jsonrpc-3436320/web/modules/custom/jsonrpc-3436320/src/Object/Response.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 58 | ERROR | Parameter $headers is not described in comment
    |       | (Drupal.Commenting.FunctionComment.ParamMissingDefinition)
--------------------------------------------------------------------------------
FILE: ...rpc-3436320/web/modules/custom/jsonrpc-3436320/src/Object/ParameterBag.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 49 | ERROR | [x] Use null coalesce operator instead of ternary operator.
    |       |     (SlevomatCodingStandard.ControlStructures.RequireNullCoalesceOperator.NullCoalesceOperatorNotUsed)
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...ue/jsonrpc-3436320/web/modules/custom/jsonrpc-3436320/src/Object/Error.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
 22 | ERROR | Missing member variable doc comment
    |       | (Drupal.Commenting.VariableComment.Missing)
 30 | ERROR | Missing member variable doc comment
    |       | (Drupal.Commenting.VariableComment.Missing)
--------------------------------------------------------------------------------
FILE: ...dules/custom/jsonrpc-3436320/src/Annotation/JsonRpcParameterDefinition.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 72 | ERROR | [x] Use null coalesce operator instead of ternary operator.
    |       |     (SlevomatCodingStandard.ControlStructures.RequireNullCoalesceOperator.NullCoalesceOperatorNotUsed)
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: .../jsonrpc-3436320/modules/jsonrpc_core/tests/src/Functional/PluginsTest.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 15 | ERROR | Missing member variable doc comment
    |       | (Drupal.Commenting.VariableComment.Missing)
--------------------------------------------------------------------------------
FILE: ...0/modules/jsonrpc_core/tests/src/Functional/MaintenanceModeEnabledTest.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 15 | ERROR | Missing member variable doc comment
    |       | (Drupal.Commenting.VariableComment.Missing)
--------------------------------------------------------------------------------
FILE: ...jsonrpc-3436320/modules/jsonrpc_core/src/Plugin/jsonrpc/Method/Plugins.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------------
 63 | WARNING | [x] Inline @var declarations should use the /** */ delimiters
    |         |     (Drupal.Commenting.InlineVariableComment.VarInline)
 65 | WARNING | [x] Inline @var declarations should use the /** */ delimiters
    |         |     (Drupal.Commenting.InlineVariableComment.VarInline)
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...3436320/modules/jsonrpc_core/src/Plugin/jsonrpc/Method/ListPermissions.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 37 | WARNING | [x] 'TODO: Fix the schema.' should match the format '@todo Fix
    |         |     problem X here.' (Drupal.Commenting.TodoComment.TodoFormat)
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...m/jsonrpc-3436320/modules/jsonrpc_core/src/Plugin/jsonrpc/Method/Cache.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 16 | WARNING | The class short comment should describe what the class does and
    |         | not simply repeat the class name
    |         | (Drupal.Commenting.ClassComment.Short)
--------------------------------------------------------------------------------
FILE: ...320/modules/jsonrpc_core/src/Plugin/jsonrpc/Method/AddPermissionToRole.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 31 | WARNING | [x] Inline @var declarations should use the /** */ delimiters
    |         |     (Drupal.Commenting.InlineVariableComment.VarInline)
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
Time: 395ms; Memory: 6MB

Comment	File	Size	Author
#5	after patch.png	103.27 KB	paraderojether
#5	before patch.png	214 KB	paraderojether

Issue fork jsonrpc-3339557

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

coding_standards changes, plain diff MR !4
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

6 February 2023 at 10:28

ptmkenny created an issue. See original summary.

Comment #2

6 February 2023 at 10:29

ptmkenny opened merge request !4

Comment #3

ptmkenny commented 6 February 2023 at 10:29

Status:

Active

» Needs review

The MR fixes all errors listed in the IS.

Comment #4

avpaderno

he/him

Italian

Brescia, 🇮🇹 🇪🇺

commented 1 May 2023 at 19:05

Title:	Fix coding standards	» Fix the issues reported by phpcs
Issue tags:		+Coding standards

Comment #5

paraderojether commented 2 May 2023 at 01:46

Status:

Needs review

» Reviewed & tested by the community

Status	File	Size
new	before patch.png	214 KB
new	after patch.png	103.27 KB

Hi ptmkenny

I reviewed MR!4, and verified it fixes all the error reported by the phpcs. Drupal core 9.5.8, JSON-RPC 2.x-dev.

I added screenshots for reference.
Thank You.

Comment #6

avpaderno

he/him

Italian

Brescia, 🇮🇹 🇪🇺

commented 20 May 2023 at 15:01

Status:

Reviewed & tested by the community

» Needs work

Comment #7

ptmkenny commented 21 May 2023 at 15:06

Status:

Needs work

» Needs review

Comment #8

ptmkenny commented 26 May 2024 at 07:47

Parent issue:

» #3436320: Add GitLab CI template

Comment #9

clarkssquared commented 26 May 2024 at 11:54

Status:

Needs review

» Needs work

I applied the updated MR !4 and there's still a PHPCS error below:

➜  jsonrpc git:(2.x) curl https://git.drupalcode.org/project/jsonrpc/-/merge_requests/4.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 10938    0 10938    0     0  16218      0 --:--:-- --:--:-- --:--:-- 16374
patching file 'modules/jsonrpc_core/src/Plugin/jsonrpc/Method/AddPermissionToRole.php'
patching file 'modules/jsonrpc_core/src/Plugin/jsonrpc/Method/Cache.php'
patching file 'modules/jsonrpc_core/src/Plugin/jsonrpc/Method/ListPermissions.php'
patching file 'modules/jsonrpc_core/src/Plugin/jsonrpc/Method/Plugins.php'
patching file 'modules/jsonrpc_core/tests/src/Functional/MaintenanceModeEnabledTest.php'
patching file 'modules/jsonrpc_core/tests/src/Functional/PluginsTest.php'
patching file 'src/Annotation/JsonRpcParameterDefinition.php'
patching file 'src/Handler.php'
patching file 'src/Object/Error.php'
patching file 'src/Object/ParameterBag.php'
patching file 'src/Object/Response.php'
patching file 'src/Plugin/JsonRpcMethodManager.php'
patching file 'src/Shaper/RpcRequestFactory.php'
patching file 'tests/src/Functional/JsonRpcTestBase.php'
patching file 'tests/src/Functional/ResponseHeadersTest.php'
➜  jsonrpc git:(2.x) ✗ ..
➜  contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml jsonrpc

FILE: ...9/d9-local/web/modules/contrib/jsonrpc/src/Plugin/JsonRpcMethodManager.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 7 | ERROR | [x] Use statements should be sorted alphabetically. The first
   |       |     wrong one is Drupal\Core\Cache\CacheBackendInterface.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...s/d9/d9-local/web/modules/contrib/jsonrpc/src/Shaper/RpcRequestFactory.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 12 | ERROR | [x] Use statements should be sorted alphabetically. The first
    |       |     wrong one is Drupal\jsonrpc\ParameterDefinitionInterface.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

Time: 646ms; Memory: 12MB

➜  contrib git:(master) ✗

Below is the full PHPCS result before and after applying the MR !4

➜  contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml jsonrpc 

FILE: ...local/web/modules/contrib/jsonrpc/tests/src/Functional/JsonRpcTestBase.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 15 | WARNING | The class short comment should describe what the class does and
    |         | not simply repeat the class name
--------------------------------------------------------------------------------


FILE: ...l/web/modules/contrib/jsonrpc/tests/src/Functional/ResponseHeadersTest.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 16 | ERROR | Missing member variable doc comment
--------------------------------------------------------------------------------


FILE: ...c/modules/jsonrpc_core/tests/src/Functional/MaintenanceModeEnabledTest.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 15 | ERROR | Missing member variable doc comment
--------------------------------------------------------------------------------


FILE: .../contrib/jsonrpc/modules/jsonrpc_core/tests/src/Functional/PluginsTest.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 15 | ERROR | Missing member variable doc comment
--------------------------------------------------------------------------------


FILE: ...rpc/modules/jsonrpc_core/src/Plugin/jsonrpc/Method/AddPermissionToRole.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 31 | WARNING | [x] Inline @var declarations should use the /** */ delimiters
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...s/contrib/jsonrpc/modules/jsonrpc_core/src/Plugin/jsonrpc/Method/Cache.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 16 | WARNING | The class short comment should describe what the class does and
    |         | not simply repeat the class name
--------------------------------------------------------------------------------


FILE: ...contrib/jsonrpc/modules/jsonrpc_core/src/Plugin/jsonrpc/Method/Plugins.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------------
 63 | WARNING | [x] Inline @var declarations should use the /** */ delimiters
 65 | WARNING | [x] Inline @var declarations should use the /** */ delimiters
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...jsonrpc/modules/jsonrpc_core/src/Plugin/jsonrpc/Method/ListPermissions.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 37 | WARNING | [x] 'TODO: Fix the schema.' should match the format '@todo Fix
    |         |     problem X here.'
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...ng-subing/Projects/d9/d9-local/web/modules/contrib/jsonrpc/src/Handler.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------------
 155 | WARNING | [x] '@TODO: Remove the following when PHP7 is the minimum
     |         |     supported version.' should match the format '@todo Fix
     |         |     problem X here.'
 218 | WARNING | [x] 'TODO: Add cacheability metadata here.' should match the
     |         |     format '@todo Fix problem X here.'
 219 | WARNING | [x] Inline @var declarations should use the /** */ delimiters
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...9/d9-local/web/modules/contrib/jsonrpc/src/Plugin/JsonRpcMethodManager.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------------
  7 | ERROR   | [x] Use statements should be sorted alphabetically. The first
    |         |     wrong one is Drupal\Core\Cache\CacheBackendInterface.
 41 | WARNING | [x] Inline @var declarations should use the /** */ delimiters
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: .../web/modules/contrib/jsonrpc/src/Annotation/JsonRpcParameterDefinition.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 72 | ERROR | [x] Use null coalesce operator instead of ternary operator.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...s/d9/d9-local/web/modules/contrib/jsonrpc/src/Shaper/RpcRequestFactory.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
--------------------------------------------------------------------------------
  12 | ERROR   | [x] Use statements should be sorted alphabetically. The first
     |         |     wrong one is Drupal\jsonrpc\ParameterDefinitionInterface.
 106 | ERROR   | [x] Use null coalesce operator instead of ternary operator.
 177 | WARNING | [x] 'TODO: Wrap other shaper transformations in a similar way
     |         |     for nicer' should match the format '@todo Fix problem X
     |         |     here.'
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...g/Projects/d9/d9-local/web/modules/contrib/jsonrpc/src/Object/Response.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 58 | ERROR | Parameter $headers is not described in comment
--------------------------------------------------------------------------------


FILE: ...bing/Projects/d9/d9-local/web/modules/contrib/jsonrpc/src/Object/Error.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
 22 | ERROR | Missing member variable doc comment
 30 | ERROR | Missing member variable doc comment
--------------------------------------------------------------------------------


FILE: ...ojects/d9/d9-local/web/modules/contrib/jsonrpc/src/Object/ParameterBag.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 49 | ERROR | [x] Use null coalesce operator instead of ternary operator.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

Time: 712ms; Memory: 12MB

➜  contrib git:(master) ✗ cd jsonrpc 
➜  jsonrpc git:(2.x) curl https://git.drupalcode.org/project/jsonrpc/-/merge_requests/4.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 10938    0 10938    0     0  16218      0 --:--:-- --:--:-- --:--:-- 16374
patching file 'modules/jsonrpc_core/src/Plugin/jsonrpc/Method/AddPermissionToRole.php'
patching file 'modules/jsonrpc_core/src/Plugin/jsonrpc/Method/Cache.php'
patching file 'modules/jsonrpc_core/src/Plugin/jsonrpc/Method/ListPermissions.php'
patching file 'modules/jsonrpc_core/src/Plugin/jsonrpc/Method/Plugins.php'
patching file 'modules/jsonrpc_core/tests/src/Functional/MaintenanceModeEnabledTest.php'
patching file 'modules/jsonrpc_core/tests/src/Functional/PluginsTest.php'
patching file 'src/Annotation/JsonRpcParameterDefinition.php'
patching file 'src/Handler.php'
patching file 'src/Object/Error.php'
patching file 'src/Object/ParameterBag.php'
patching file 'src/Object/Response.php'
patching file 'src/Plugin/JsonRpcMethodManager.php'
patching file 'src/Shaper/RpcRequestFactory.php'
patching file 'tests/src/Functional/JsonRpcTestBase.php'
patching file 'tests/src/Functional/ResponseHeadersTest.php'
➜  jsonrpc git:(2.x) ✗ ..
➜  contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml jsonrpc

FILE: ...9/d9-local/web/modules/contrib/jsonrpc/src/Plugin/JsonRpcMethodManager.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 7 | ERROR | [x] Use statements should be sorted alphabetically. The first
   |       |     wrong one is Drupal\Core\Cache\CacheBackendInterface.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...s/d9/d9-local/web/modules/contrib/jsonrpc/src/Shaper/RpcRequestFactory.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 12 | ERROR | [x] Use statements should be sorted alphabetically. The first
    |       |     wrong one is Drupal\jsonrpc\ParameterDefinitionInterface.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

Time: 646ms; Memory: 12MB

➜  contrib git:(master) ✗

Moving this to needs work

Comment #10

ptmkenny commented 26 May 2024 at 12:02

Status:

Needs work

» Needs review

@clarkssquared Good catch, the coding standards had been updated since this was originally submitted.

Comment #11

clarkssquared commented 26 May 2024 at 12:56

Hi ptmkenny,

I applied the updated MR !4 after commit 873f5808, and I confirmed that there are no PHPCS issues

➜  jsonrpc git:(2.x) curl https://git.drupalcode.org/project/jsonrpc/-/merge_requests/4.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 11826    0 11826    0     0  26106      0 --:--:-- --:--:-- --:--:-- 26456
patching file 'modules/jsonrpc_core/src/Plugin/jsonrpc/Method/AddPermissionToRole.php'
patching file 'modules/jsonrpc_core/src/Plugin/jsonrpc/Method/Cache.php'
patching file 'modules/jsonrpc_core/src/Plugin/jsonrpc/Method/ListPermissions.php'
patching file 'modules/jsonrpc_core/src/Plugin/jsonrpc/Method/Plugins.php'
patching file 'modules/jsonrpc_core/tests/src/Functional/MaintenanceModeEnabledTest.php'
patching file 'modules/jsonrpc_core/tests/src/Functional/PluginsTest.php'
patching file 'src/Annotation/JsonRpcParameterDefinition.php'
patching file 'src/Handler.php'
patching file 'src/Object/Error.php'
patching file 'src/Object/ParameterBag.php'
patching file 'src/Object/Response.php'
patching file 'src/Plugin/JsonRpcMethodManager.php'
patching file 'src/Shaper/RpcRequestFactory.php'
patching file 'tests/src/Functional/JsonRpcTestBase.php'
patching file 'tests/src/Functional/ResponseHeadersTest.php'
➜  jsonrpc git:(2.x) ✗ ..
➜  contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml jsonrpc            
➜  contrib git:(master) ✗

RTBC +1 from me, I will retain the status to needs review for others to also give their feedbacks.

Comment #12

avpaderno

he/him

Italian

Brescia, 🇮🇹 🇪🇺

commented 26 May 2024 at 20:56

Issue summary:

View changes

Comment #13

ptmkenny commented 30 August 2024 at 22:52

Comment #14

30 August 2024 at 22:52

ptmkenny committed fd6f1499 on 2.x

Issue #3339557 by ptmkenny, paraderojether, avpaderno, clarkssquared:...

Comment #15

ptmkenny commented 30 August 2024 at 22:52

Status:

Needs review

» Fixed

Comment #16

13 September 2024 at 22:54

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Fix the issues reported by phpcs

Issue fork jsonrpc-3339557

Comments

Comment #1

Comment #2

Comment #3

Comment #4

Comment #5

Comment #6

Comment #7

Comment #8

Comment #9

Comment #10

Comment #11

Comment #12

Comment #13

Comment #14

Comment #15

Comment #16

Parent issue

News items

Our community

Documentation

Drupal code base

Governance of community