Problem/Motivation

Getting Following errors/warnings

$ phpcs --standard=Drupal views_autosubmit

FILE: C:\Users\Admin\Desktop\task\views_autosubmit\js\views_autosubmit.js
--------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
--------------------------------------------------------------------------------
  1 | ERROR | [x] End of line character is invalid; expected "\n" but found
    |       |     "\r\n"
  8 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
 10 | ERROR | [x] Expected 0 spaces before opening parenthesis; 1 found
 49 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
 58 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...Desktop\task\views_autosubmit\src\Plugin\views\exposed_form\Autosubmit.php
--------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
--------------------------------------------------------------------------------
  1 | ERROR | [x] End of line character is invalid; expected "\n" but found
    |       |     "\r\n"
 22 | ERROR | [ ] Doc comment short description must start with a capital
    |       |     letter
 33 | ERROR | [ ] Doc comment short description must start with a capital
    |       |     letter
 47 | ERROR | [ ] Doc comment short description must start with a capital
    |       |     letter
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

Time: 437ms; Memory: 8MB

Proposed resolution

Fix the errors and warnings.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Jay Jangid created an issue. See original summary.

jay jangid’s picture

Assigned: jay jangid » Unassigned
Status: Active » Needs review

Created MR , please review.

Thank you.

riddhi.addweb’s picture

Status: Needs review » Needs work
StatusFileSize
new107.87 KB

Hello, I tried applying the 3339500 patch, but an error is displayed while the user applies the patch. Please check it from your end once. Also attaching Screenshots for the same.

manish-31 made their first commit to this issue’s fork.

manish-31’s picture

Status: Needs work » Needs review

MR rebased and fixed new PHPCS issues. @riddhi.addweb Please review now you should be able to apply the MR patch.

riddhi.addweb’s picture

StatusFileSize
new119.21 KB

The mentioned phpcs issue is resolved, & I have also checked and it is working as expected. I am attaching the Screenshots & doing RTBC for the same.

riddhi.addweb’s picture

Status: Needs review » Reviewed & tested by the community
i-trokhanenko’s picture

Status: Reviewed & tested by the community » Patch (to be ported)

i-trokhanenko’s picture

Status: Patch (to be ported) » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.