malaussene -
(by request, new issue from #22 in #233457: Drupal 6?)
I initially tested with current versions of 6.x core (6.5 & 6.6) and with cck 6.x-2.0-rc10.
* the phone number not saving data is still happening.
But what I think is going on is validation. If I add an actual phone number, it shows up fine. But if I add a bogus phone number, like 1 (215) 1234567, I get a blank result that follows my phone display format such as 1 () - (displaying country code plus area code in brackets, but no phone number).
I think the validation should display a friendly message on the edit form instead like "this does not appear to be a valid US or Canadian phone number - please enter a valid number" etc.
:)
Scott
Comments
Comment #1
scottrigby^^ Edit above: my initial sub-issue was from #18 in that issue, not #22 :)
Ok, so now tested patch (from #22 in above issue) with current version of 6.x core (6.6) and with CCK 6.x-2.1.
* Phone number saves now
* Friendly message when not valid number
Great work!
Marking as 'Patch: code needs review' (at least one other person?)
Here is the patch to make it easy.
Note: this patch is against the patched version of HEAD in #6 of the issue above - here
Really looking forward to seeing a 6.x-1.x-dev (trackable) release!
Cheers -
Scott
Comment #2
thierry_gd commentedTaken into account in latest 5.x and 6.x versions
Comment #3
thierry_gd commentedForgot to change the status