Problem/Motivation

Drupal 10 is released on 14 December and Theme is not found compatible with it.

CommentFileSizeAuthor
#2 theme-compatibility-3337553-2.patch587 bytesashutosh ahirwal
#6 theme-compatibility-3337553-3.patch2.89 KBashishsingh27
#9 PortD9toD10#9.patch2.76 KBabh1shek chauhan
#9 Screenshot from 2023-04-05 10-41-30.png63.1 KBabh1shek chauhan

Issue fork fashion_beauty-3337553

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Ashutosh Ahirwal created an issue. See original summary.

ashutosh ahirwal’s picture

ashutosh ahirwal commented
Assigned: ashutosh ahirwal » Unassigned
Status: Needs work » Needs review
StatusFileSize
new theme-compatibility-3337553-2.patch587 bytes

Providing patch for reference.
theme-compatibility

annmarysruthy made their first commit to this issue’s fork.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: Theme is not compatible with Drupal10 » Make the theme compatible with Drupal 10
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Priority: Minor » Normal
Status: Needs review » Needs work 
 core: 8.x
-core_version_requirement: ^8 || ^9
+core_version_requirement: ^8 || ^9 || ^10

core cannot be used with that value of core_version_requirement.

ashishsingh27’s picture

ashishsingh27 commented
StatusFileSize
new theme-compatibility-3337553-3.patch2.89 KB

Here is a patch to get it working on drupal 10.

As mentioned by @apaderno, since, core can not be used have removed it. and added it like core_version_requirement: ^8.8 || ^9 || ^10.

prior to 8.7 core_version_requiremnt is not there.
maybe this link will be helpful https://www.drupal.org/node/3070687

Also, for File::load($fid[0]) it was getting null value hence have added condition to check for Null.

ashishsingh27’s picture

ashishsingh27 commented
Status: Needs work » Needs review
abh1shek chauhan’s picture

abh1shek chauhan commented

@ashishsingh27 I have tested this theme on my local drupal 10 setup and it's giving error with drupal-check.

abh1shek chauhan’s picture

abh1shek chauhan commented
StatusFileSize
new PortD9toD10#9.patch2.76 KB
new Screenshot from 2023-04-05 10-41-30.png63.1 KB

@ashishsingh27 I've created a new patch for it. It is working fine now. Please apply this patch and test it in your local drupal D10 setup.

abh1shek chauhan’s picture

abh1shek chauhan commented
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue tags: -Novice

Since there are not clear instructions a novice user can follow, this is not a novice issue.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Needs work 
 core: 8.x
-core_version_requirement: ^8 || ^9
+core_version_requirement: ^8 || ^9 || ^10

With that core_version_requirement value, core cannot be anymore used. Also, core_version_requirement should be core_version_requirement: ^8.8 || ^9 || ^10 because core_version_requirement is not recognized in earlier Drupal versions.

Has anybody verified the code is really compatible with Drupal 10? Is the code still using functions/methods that have been removed from Drupal 10?

shivam_tiwari’s picture

shivam_tiwari commented
Assigned: Unassigned » shivam_tiwari

shivam_tiwari opened merge request !1

shivam_tiwari’s picture

shivam_tiwari commented
Assigned: shivam_tiwari » Unassigned
Status: Needs work » Needs review

arti_parmar made their first commit to this issue’s fork.

arti_parmar’s picture

arti_parmar commented
Status: Needs review » Fixed

I have reviewed the changes and tested them. I will merge them.

arti_parmar opened merge request !2

arti_parmar’s picture

arti_parmar commented
Status: Fixed » Closed (fixed)