Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects

Periodically patches will be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted simply close this issue (any status besides Active, Needs review or Needs work) or remove the "ProjectUpdateBotD10" tag from the issue.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review or Needs work) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but don't want new automated patches simply leave this issue open but remove the "ProjectUpdateBotD10" tag from the issue.

    You can use Drupal Rector yourself to make these patches.

    If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review or Needs work) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it may be useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the patch in the comment by Project Update Bot.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Infrastructure project issue queue using the component “Bot: Drupal Rector”.

Real-physical-testing-round-for-Block-Library-1-0-x-dev--with-d10-and-d9.zip

CommentFileSizeAuthor
#15 Edit-layout-for-Test-a-Web-Page-with-Layout-Builder-and-Block-Library-Block-Library-1-0-x-dev-Real-physical-testing-with-Drupal-9.png275.2 KBrajab natshah
#15 Edit-layout-for-Test-a-Web-Page-with-Layout-Builder-and-Block-Library-Block-Library-1-0-x-dev-Real-physical-testing-with-Drupal-10.png278.19 KBrajab natshah
#15 Real-physical-testing-round-for-Block-Library-1-0-x-dev--with-d10-and-d9.zip2.73 KBrajab natshah
#14 3296653-14.patch3.64 KBrajab natshah
#11 3296653-11.patch3.09 KBrajab natshah
#9 3296653-9.patch2.58 KBrajab natshah
#7 single-export-block_library-2023-01-29T20_48_26+0300.txt5.12 KBrajab natshah
#3 block_library.1.0.x-dev.rector.patch933 bytesproject update bot
#3 interdiff-last-bot.6658220.txt927 bytesproject update bot
#2 block_library.1.0.x-dev.rector.patch1.75 KBproject update bot

Issue fork block_library-3296653

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

project update bot commented
Status: Active » Needs review
StatusFileSize
new block_library.1.0.x-dev.rector.patch1.75 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module this patch makes this module compatible with Drupal 10! 🎉
This patch updates the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #139

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.24
  2. palantirnet/drupal-rector: 0.13.0
project update bot’s picture

project update bot commented
StatusFileSize
new interdiff-last-bot.6658220.txt927 bytes
new block_library.1.0.x-dev.rector.patch933 bytes

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.13.0, cannot fix all Drupal 10 compatibility problems.

This patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #143

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.25
  2. palantirnet/drupal-rector: 0.13.0

j_ten_man made their first commit to this issue’s fork.

rajab natshah’s picture

rajab natshah
he/him
commented
Priority: Normal » Major
Issue summary: View changes
rajab natshah’s picture

rajab natshah
he/him
commented
Priority: Major » Critical
rajab natshah’s picture

rajab natshah
he/him
commented
StatusFileSize
new single-export-block_library-2023-01-29T20_48_26+0300.txt5.12 KB

Upgrade Status report

Block Library 1.0.0-alpha2

Scanned on Sun, 01/29/2023 - 20:48.
2 errors found. 3 warnings found.

Fix now with automation

Avoid some manual work by using drupal-rector to fix issues automatically or Upgrade Rector to generate patches.
CONTRIBUTED PROJECTS
--------------------------------------------------------------------------------
Block Library 1.0.0-alpha2
Scanned on Sun, 01/29/2023 - 20:48.

2 errors found. 3 warnings found. Avoid some manual work by using drupal-rector
for fixing issues automatically or Upgrade Rector to generate patches.

modules/contrib/block_library/src/Controller/ChooseBlockController.php:
┌──────────┬──────┬──────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                           MESSAGE                            │
├──────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Check    │ 16   │ Class Drupal\block_library\Controller\ChooseBlockController  │
│ manually │      │ extends @internal class                                      │
│          │      │ Drupal\layout_builder_restrictions\Controller\ChooseBlockCon │
│          │      │ troller.                                                     │
│          │      │                                                              │
│ Fix with │ 34   │ Call to deprecated function file_create_url(). Deprecated in │
│ rector   │      │ drupal:9.3.0 and is removed from drupal:10.0.0. Use the      │
│          │      │ appropriate method on                                        │
│          │      │ \Drupal\Core\File\FileUrlGeneratorInterface instead.         │
│          │      │                                                              │
│ Fix with │ 34   │ Call to deprecated function file_url_transform_relative().   │
│ rector   │      │ Deprecated in drupal:9.3.0 and is removed from               │
│          │      │ drupal:10.0.0. Use                                           │
│          │      │ Drupal\Core\File\FileUrlGenerator::transformRelative()       │
│          │      │ instead.                                                     │
│          │      │                                                              │
└──────────┴──────┴──────────────────────────────────────────────────────────────┘

modules/contrib/block_library/block_library.info.yml:
┌──────────┬──────┬────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                          MESSAGE                           │
├──────────┼──────┼────────────────────────────────────────────────────────────┤
│ Check    │ 0    │ Value of core_version_requirement: ^8 || ^9 is not         │
│ manually │      │ compatible with the next major version of Drupal core. See │
│          │      │ https://drupal.org/node/3070687.                           │
│          │      │                                                            │
└──────────┴──────┴────────────────────────────────────────────────────────────┘

modules/contrib/block_library/composer.json:
┌──────────┬──────┬──────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                           MESSAGE                            │
├──────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Check    │ 0    │ The drupal/core requirement is not compatible with the next  │
│ manually │      │ major version of Drupal. Either remove it or update it to be │
│          │      │ compatible. See                                              │
│          │      │ https://drupal.org/node/2514612#s-drupal-9-compatibility.    │
│          │      │                                                              │
└──────────┴──────┴──────────────────────────────────────────────────────────────┘
rajab natshah’s picture

rajab natshah
he/him
commented

phpcs --standard=Drupal

rajab@vardot-dev:/var/www/html/modules/block_library$ phpcs --standard=Drupal --extensions=php,inc,install,test,profile,theme,css,info,txt,md,yml,js /var/www/html/modules/block_library/

phpcs --standard=DrupalPractice

rajab@vardot-dev:/var/www/html/modules/block_library$ phpcs --standard=DrupalPractice --extensions=php,inc,install,test,profile,theme,css,info,txt,md,yml,js /var/www/html/modules/block_library/
rajab natshah’s picture

rajab natshah
he/him
commented
StatusFileSize
new 3296653-9.patch2.58 KB
rajab natshah’s picture

rajab natshah
he/him
commented 
PHP Fatal error:  Declaration of Drupal\block_library\Routing\RouteSubscriber::getSubscribedEvents() must be compatible with Drupal\Core\Routing\RouteSubscriberBase::getSubscribedEvents(): array in /var/www/html/sandboxes/drupal10block_library_1__test/web/modules/contrib/block_library/src/Routing/RouteSubscriber.php on line 28
rajab natshah’s picture

rajab natshah
he/him
commented
StatusFileSize
new 3296653-11.patch3.09 KB
rajab natshah’s picture

rajab natshah
he/him
commented
rajab natshah’s picture

rajab natshah
he/him
commented

When creating a new block type with an icon

The website encountered an unexpected error. Please try again later.
TypeError: mb_strlen(): Argument #1 ($string) must be of type string, array given in mb_strlen() (line 333 of core/lib/Drupal/Core/Form/FormValidator.php).
mb_strlen() (Line: 333)
Drupal\Core\Form\FormValidator->performRequiredValidation() (Line: 246)
Drupal\Core\Form\FormValidator->doValidateForm() (Line: 238)
Drupal\Core\Form\FormValidator->doValidateForm() (Line: 238)
Drupal\Core\Form\FormValidator->doValidateForm() (Line: 118)
Drupal\Core\Form\FormValidator->validateForm() (Line: 591)
Drupal\Core\Form\FormBuilder->processForm() (Line: 323)
Drupal\Core\Form\FormBuilder->buildForm() (Line: 73)
Drupal\Core\Controller\FormController->getContentResult() (Line: 39)
Drupal\layout_builder\Controller\LayoutBuilderHtmlEntityFormController->getContentResult()
call_user_func_array() (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 580)
Drupal\Core\Render\Renderer->executeInRenderContext() (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext() (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 169)
Symfony\Component\HttpKernel\HttpKernel->handleRaw() (Line: 81)
Symfony\Component\HttpKernel\HttpKernel->handle() (Line: 58)
Drupal\Core\StackMiddleware\Session->handle() (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle() (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass() (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle() (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle() (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle() (Line: 23)
Stack\StackedHttpKernel->handle() (Line: 713)
Drupal\Core\DrupalKernel->handle() (Line: 19)
rajab natshah’s picture

rajab natshah
he/him
commented
StatusFileSize
new 3296653-14.patch3.64 KB
rajab natshah’s picture

rajab natshah
he/him
commented
Issue summary: View changes
StatusFileSize
new Real-physical-testing-round-for-Block-Library-1-0-x-dev--with-d10-and-d9.zip2.73 KB
new Edit-layout-for-Test-a-Web-Page-with-Layout-Builder-and-Block-Library-Block-Library-1-0-x-dev-Real-physical-testing-with-Drupal-10.png278.19 KB
new Edit-layout-for-Test-a-Web-Page-with-Layout-Builder-and-Block-Library-Block-Library-1-0-x-dev-Real-physical-testing-with-Drupal-9.png275.2 KB

Had Real physical testing round for Block Library 1.0.x-dev with Drupal ~10

also
Had Real physical testing round for Block Library 1.0.x-dev with Drupal ~9

using the attached bash commands
Real-physical-testing-round-for-Block-Library-1-0-x-dev--with-d10-and-d9.zip

Rajab Natshah opened merge request !3

mahmoud-zayed’s picture

mahmoud-zayed commented
Status: Needs review » Fixed
mahmoud-zayed’s picture

mahmoud-zayed commented
Status: Fixed » Closed (fixed)

Thanks Rajab :)