Problem/Motivation
In #3123832: [META] Fix @todo items referencing closed issues we discovered that there's a @todo in core/modules/system/tests/themes/test_legacy_theme/test_legacy_theme.theme which references a d.o. issue that is already closed; #3097889: Remove deprecated theme functions
Here's the @todo:
/**
* @file
* Theme to test functionality of legacy theme functions.
*
* @todo Remove in https://www.drupal.org/project/drupal/issues/3097889
*/
Steps to reproduce
Proposed resolution
Looking at the commit in #3097889: Remove deprecated theme functions, all the testing of the legacy methods are deleted, but somehow stayed around in the .theme-file.
Since they are not being tested, we can remove that file.
When we're doing that, we are left with a test theme that now only only used for testing deprecated libraries.
Let's rename the test theme so that it reflects is new, sole purpose.
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Issue fork drupal-3337195
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3337195-rename-test-theme
changes, plain diff MR !3319
Comments
Comment #3
spokjeComment #4
spokjeComment #5
smustgrave commentedLooks like a simple enough change that didn't break anything.
Comment #6
alexpottCommitted and pushed bad3316004 to 10.1.x and a8ca27f4cf to 10.0.x. Thanks!
Backported to 10.0.x as this is a test-only change. And this keeps the tests in 10.0.x and 10.1.x aligned.