Problem/Motivation

HEAD tests are failing

Steps to reproduce

I will prove this

Proposed resolution

update the core patch that is required by this module.

Remaining tasks

determine whether the problem is with webform_revision_ui or the drupal testbot it'self

CommentFileSizeAuthor
#10 3336449-10.patch1.39 KBjoseph.olstad
#8 3336449-08.patch1.27 KBjoseph.olstad
#4 no_change_test_3336449-03.patch245 bytesjoseph.olstad
#4 with_changes_test_3336449-03.patch713 bytesjoseph.olstad
#2 3336449-02.patch708 bytesjoseph.olstad

Comments

joseph.olstad created an issue. See original summary.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
StatusFileSize
new 3336449-02.patch708 bytes

see patch

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Active » Needs review
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
StatusFileSize
new with_changes_test_3336449-03.patch713 bytes
new no_change_test_3336449-03.patch245 bytes
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Title: Fix head tests » Fix webform_revision_ui head tests

The last submitted patch, 4: with_changes_test_3336449-03.patch, failed testing. View results

Status: Needs review » Needs work

The last submitted patch, 4: no_change_test_3336449-03.patch, failed testing. View results

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
StatusFileSize
new 3336449-08.patch1.27 KB

see new patch

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Needs work » Needs review
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
StatusFileSize
new 3336449-10.patch1.39 KB

new patch

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Issue summary: View changes

Status: Needs review » Needs work

The last submitted patch, 10: 3336449-10.patch, failed testing. View results

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented

#2350939: Implement a generic revision UI is committed now. Can we add the Drupal core constraint to the info file and remove the patch for testing?

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Needs work » Postponed

This will be fixed by
committing /merging this for the required module "config_revision":
#3451887: Automated Drupal 11 compatibility fixes for config_revision

Followed by merging/committing this:
#3435672: Automated Drupal 11 compatibility fixes for webform_revision_ui

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Parent issue: » #3451887: Automated Drupal 11 compatibility fixes for config_revision
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Related issues: +#3435672: Automated Drupal 11 compatibility fixes for webform_revision_ui
jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Title: Fix webform_revision_ui head tests » Fix webform_revision_ui HEAD tests
Status: Postponed » Active

This one is back to active.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented

This is the latest error.

There was 1 error:
1) Drupal\Tests\webform_revision_ui\Functional\WebformRevisionUiTest::testConfigRevisionWebform
Exception: User notice: The function w() is registered for more than one of the alter hooks ['form_alter', 'form_config_revision_revision_revert_alter', 'form_config_revision_revision_revert_alter'] from the current ->alter() call. Only one instance will be part of the implementation list for this hook combination.
Drupal\Core\Extension\ModuleHandler->triggerErrorForDuplicateAlterHookListener()() (Line: 601)
/builds/project/webform_revision_ui/web/core/lib/Drupal/Core/Test/HttpClientMiddleware/TestHttpClientMiddleware.php:55
/builds/project/webform_revision_ui/vendor/guzzlehttp/promises/src/Promise.php:209
/builds/project/webform_revision_ui/vendor/guzzlehttp/promises/src/Promise.php:158
/builds/project/webform_revision_ui/vendor/guzzlehttp/promises/src/TaskQueue.php:52
/builds/project/webform_revision_ui/vendor/guzzlehttp/promises/src/Promise.php:251
/builds/project/webform_revision_ui/vendor/guzzlehttp/promises/src/Promise.php:227
/builds/project/webform_revision_ui/vendor/guzzlehttp/promises/src/Promise.php:272
/builds/project/webform_revision_ui/vendor/guzzlehttp/promises/src/Promise.php:229
/builds/project/webform_revision_ui/vendor/guzzlehttp/promises/src/Promise.php:69
/builds/project/webform_revision_ui/vendor/guzzlehttp/guzzle/src/Client.php:189
/builds/project/webform_revision_ui/web/core/tests/Drupal/Tests/DrupalTestBrowser.php:139
/builds/project/webform_revision_ui/vendor/symfony/browser-kit/AbstractBrowser.php:378
/builds/project/webform_revision_ui/vendor/behat/mink-browserkit-driver/src/BrowserKitDriver.php:122
/builds/project/webform_revision_ui/vendor/behat/mink/src/Session.php:175
/builds/project/webform_revision_ui/web/core/tests/Drupal/Tests/UiHelperTrait.php:277
/builds/project/webform_revision_ui/tests/src/Functional/WebformRevisionUiTest.php:159
ERRORS!
jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Active » Needs work

See https://git.drupalcode.org/project/webform_revision_ui/-/jobs/6260868